-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate RBD plugin from available in-tree drivers #118552
Conversation
/sig storage /assign @msau42 @xing-yang @jsafrane |
@humblec: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-longterm |
@carlory, I filed this PR as mentioned here kubernetes/enhancements#4035 (comment), didn't know in between a PR was filed , appreciate if you can notify upfront to avoid duplicate effort and better tracking. btw, there are more changes need to be added as in this PR compared to your PR.. please let me know how can we proceed , I am fine with tracking it either here or in the referenced one.. I am rebasing this PR regardless. thanks! |
Sorry, It‘s my mistake. Let's continue with this pr. |
nw at all 👍 , thanks for proactively filing it and its my mistake that, I took it for granted and didn't look into existing PR list.. I have also added you as co-author here 👍 .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the persistentVolumeSource
field is invisible to the user.
[root@master ~]# kubectl explain pv.spec.persistentVolumeSource.rbd
KIND: PersistentVolume
VERSION: v1
error: field "rbd" does not exist
[root@master ~]# kubectl explain pv.spec.rbd
KIND: PersistentVolume
VERSION: v1
FIELD: rbd <RBDPersistentVolumeSource>
so we need remove it.
@carlory I have accommodated the review comments, however at least in tests, it is better to be verbose as its not user facing.. regardless, lets see what others think. |
Based on https://groups.google.com/g/kubernetes-sig-storage/c/h5751_B5LQM, the consensus was to start the deprecation in v1.28. This commit start the deprecation process of RBD plugin from in-tree drivers. ACTION REQUIRED: RBD volume plugin ( `kubernetes.io/rbd`) has been deprecated in this release and will be removed in a subsequent release. Alternative is to use RBD CSI driver (https://github.com/ceph/ceph-csi/) in your Kubernetes Cluster. Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]> Signed-off-by: carlory <[email protected]>
@jsafrane @xing-yang @msau42 can you please help to review this PR ? |
/lgtm |
LGTM label has been added. Git tree hash: 31a76085e729c7059575a5ff1bfde36cd8280ffe
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: humblec, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
Based on
https://groups.google.com/g/kubernetes-sig-storage/c/h5751_B5LQM, the consensus was to start the deprecation in v1.28.
This commit start the deprecation process of RBD plugin from in-tree drivers.
/kind deprecation