-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix 'pod' in kubelet prober metrics #118549
Conversation
Hi @a7i. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@rajeeshckr: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/triage accepted |
/retest-required |
Please consider back porting this fix to supported releases - 1.25+. Thanks! |
Hi, thank you for making this simple revert. I wonder why the issue has not been yet targeted by the core team as it seems clear. |
I think we should take the revert and return to prior behavior given the regression. Would like @SergeyKanzhelev to chime in as well since he reviewed prior PR. /lgtm |
LGTM label has been added. Git tree hash: e3edc4be51d2d79b817e50e33f20882a4cc59f75
|
pending review from a few others. /hold |
/milestone v1.28 |
/milestone v1.28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
The concern was the cardinality explosion as pod name has replica's random part. However we are not making things worse exponentially - we already had a metric for success.
I think the right long term fix will be having this logic as a default, but also allow to override the app name in those metrics based on some attributes
/approve per discussion on slack and here, we need to get this in. |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a7i, dims, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…upstream-release-1.25 Automated cherry pick of #118549: fix 'pod' in kubelet prober metrics
…upstream-release-1.26 Automated cherry pick of #118549: fix 'pod' in kubelet prober metrics
…upstream-release-1.27 Automated cherry pick of #118549: fix 'pod' in kubelet prober metrics
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #115766
Special notes for your reviewer:
Kubernetes 1.25 Metric:
Kubernetes 1.24 Metric:
This breaking change causes the metrics to not get processed by datadog core which relies on actual pod name.
Does this PR introduce a user-facing change?
Yes, but it reverts to initial functionality.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @jackfrancis @SergeyKanzhelev from discussion here