Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump distroless-iptables to v0.2.5 #118541

Merged
merged 1 commit into from
Jun 7, 2023
Merged

bump distroless-iptables to v0.2.5 #118541

merged 1 commit into from
Jun 7, 2023

Conversation

jeremyrickard
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Updates distoless-iptables to use the new released image registry.k8s.io/build-image/distroless-iptables:v0.2.5 which uses Go 1.20.5

Which issue(s) this PR fixes:

xref: kubernetes/release#3099

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated distroless I-tables to use registry.k8s.io/build-image/distroless-iptables:v0.2.5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @saschagrunert @cpanato @dims
/cc @kubernetes/release-engineering

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

@jeremyrickard: GitHub didn't allow me to request PR reviews from the following users: kubernetes/release-engineering.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Updates distoless-iptables to use the new released image registry.k8s.io/build-image/distroless-iptables:v0.2.5 which uses Go 1.20.5

Which issue(s) this PR fixes:

xref: kubernetes/release#3099

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Updated distroless I-tables to use registry.k8s.io/build-image/distroless-iptables:v0.2.5

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @saschagrunert @cpanato @dims
/cc @kubernetes/release-engineering

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jun 7, 2023
@jeremyrickard
Copy link
Contributor Author

This is draft until we finish image promotion!

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 7, 2023
@jeremyrickard jeremyrickard mentioned this pull request Jun 7, 2023
Closed
32 tasks
@cpanato
Copy link
Member

cpanato commented Jun 7, 2023

/lgtm after the promotion :)

@jeremyrickard jeremyrickard marked this pull request as ready for review June 7, 2023 18:50
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@jeremyrickard
Copy link
Contributor Author

jeremyrickard commented Jun 7, 2023 •
edited

image promotion was successful :)

Image promotion seems to not have been successful?

@jeremyrickard
Copy link
Contributor Author

/retest

@dims
Copy link
Member

dims commented Jun 7, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c45e6c693b48aac9f3d3cab56bbb342e975b1acf

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jeremyrickard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit f17e275 into kubernetes:master Jun 7, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 7, 2023
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dims dims

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeremyrickard @k8s-ci-robot @cpanato @dims @saschagrunert