KEP-2305: introduce allow-metric-labels-manifest #118299
Conversation
|
Skipping CI for Draft Pull Request. |
44d5fe9
to
9595962
Compare
ebf5d88
to
a725778
Compare
|
/triage accepted |
(as per the prr review) Signed-off-by: Pranshu Srivastava <[email protected]>
| } | ||
| err = yaml.Unmarshal(data, &allowListMapping) | ||
| if err != nil { | ||
| klog.Errorf("Failed to parse allow list manifest: %v", err) |
There was a problem hiding this comment.
Should there be error handling / panic or something here? Is logging sufficient? @logicalhan what is the expectation here?
There was a problem hiding this comment.
Falling back to default behavior seems fine. I wouldn't want this to explode people.
|
/milestone v1.28 |
|
LGTM label has been added. Git tree hash: 9fdfc979adfc6b317c2891351d5bb13f962577e5
|
|
/assign @deads2k |
|
As per slack discussion moving this out of the current milestone. /milestone next |
|
@furkatgofurov7: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/milestone next-candidate |
|
/assign @johnbelamaric (since this needs an approval from anyone of the following) Lines 4 to 7 in ae02d1c |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbelamaric, logicalhan, rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rexagod: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Refer: kubernetes/kubernetes#118299. Signed-off-by: Pranshu Srivastava <[email protected]>
What type of PR is this?
/kind feature
What this PR does / why we need it:
Enable configuring the allow-list by reading a manifest. This is done as a part of graduating kubernetes/enhancements#2305 to beta.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: