Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move non-graceful node shutdown to GA #118228

Merged
merged 1 commit into from
Jul 13, 2023
Merged

move non-graceful node shutdown to GA #118228

merged 1 commit into from
Jul 13, 2023
+8 −22

Conversation

carlory
Copy link
Member

@carlory carlory commented May 24, 2023

What type of PR is this?

/kind feature
/sig storage
/priority important-soon

What this PR does / why we need it:

Move KEP-2268 Non-graceful node shutdown to GA

Which issue(s) this PR fixes:

xref: kubernetes/enhancements#4029

Special notes for your reviewer:

Does this PR introduce a user-facing change?

move non-graceful node shutdown to GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/2268-non-graceful-shutdown

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 24, 2023
This was referenced May 24, 2023
Merged
Closed
@carlory carlory force-pushed the move-non-graceful-node-shutdown-to-GA branch from e4af39c to c79f4a9 Compare May 24, 2023 11:58
@carlory
Copy link
Member Author

carlory commented May 25, 2023

/milestone 1.28

@k8s-ci-robot
Copy link
Contributor

@carlory: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carlory
Copy link
Member Author

carlory commented May 25, 2023

/cc @atiratree @dchen1107

@YuikoTakada
Copy link
Contributor

Thank you for your PR.
This file should be removed? I'm not sure.
https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/non_graceful_node_shutdown.go

About other files, looks good to me.

@carlory
Copy link
Member Author

carlory commented May 25, 2023 •
edited

Nice finding, thanks!

I think it is necessary to keep this file.

Maybe we need to change or delete this text [Feature:NodeOutOfServiceVolumeDetach]. I don't know how to modify it correctly.

Hope someone can give me some advice!

@xing-yang
Copy link
Contributor

Hi @carlory, thanks for the PR. @sonasingh46 is working on adding more e2e tests. He'll be updating the existing e2e tests.

/assign @sonasingh46

@xing-yang
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 22, 2023
@carlory carlory force-pushed the move-non-graceful-node-shutdown-to-GA branch from c79f4a9 to 5bedb22 Compare June 26, 2023 05:40
@xing-yang
Copy link
Contributor

@carlory Can you resolve the conflicts?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@xing-yang
Copy link
Contributor

/assign @gnufied @msau42

@carlory carlory force-pushed the move-non-graceful-node-shutdown-to-GA branch from 5bedb22 to f443c45 Compare July 11, 2023 05:52
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 11, 2023
@carlory
Copy link
Member Author

carlory commented Jul 11, 2023

@xing-yang updated.

@carlory
Copy link
Member Author

carlory commented Jul 11, 2023

/test pull-kubernetes-integration

@xing-yang
Copy link
Contributor

/retest

sonasingh46
sonasingh46 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@sonasingh46 sonasingh46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 951c47f553d79814bb8a0844344a6b2437a85faa

@sonasingh46
Copy link
Contributor

The e2e test PR is here.
#118848

@gnufied
Copy link
Member

gnufied commented Jul 13, 2023

/lgtm

@xing-yang
Copy link
Contributor

/lgtm
/approve

@xing-yang
Copy link
Contributor

/assign @soltysh @janetkuo @kow3ns

@xing-yang
Copy link
Contributor

/assign @dims

@xing-yang
Copy link
Contributor

/milestone 1.28

@k8s-ci-robot
Copy link
Contributor

@xing-yang: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.16, v1.17, v1.18, v1.19, v1.20, v1.21, v1.22, v1.23, v1.24, v1.25, v1.26, v1.27, v1.28]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xing-yang
Copy link
Contributor

/milestone v1.28

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 13, 2023
@janetkuo
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, janetkuo, sonasingh46, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hailkomputer
Copy link
Member

Hi! Bug triage team shadow here.

We are currently in Week 9 of the v1.28 release cycle, and the code freeze is happening next week (Week 10) at 01:00 UTC Wednesday 19th July 2023 / 18:00 PDT Tuesday 18th July 2023

Please ensure all necessary contributions are made before the deadline if the PR still targets v1.28.

Let me know if you need any assistance.

@xing-yang
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit be2cfc9 into kubernetes:master Jul 13, 2023
18 checks passed
@carlory carlory deleted the move-non-graceful-node-shutdown-to-GA branch July 14, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@janetkuo janetkuo janetkuo approved these changes

@sonasingh46 sonasingh46 sonasingh46 approved these changes

@atiratree atiratree Awaiting requested review from atiratree

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@gnufied gnufied

@dims dims

@soltysh soltysh

@xing-yang xing-yang

@janetkuo janetkuo

@kow3ns kow3ns

@msau42 msau42

@sonasingh46 sonasingh46

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet