Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove helper function for unused storage feature in pkg/proxy/util #118128

Merged
merged 1 commit into from
Jun 14, 2023
Merged

remove helper function for unused storage feature in pkg/proxy/util #118128

merged 1 commit into from
Jun 14, 2023
+25 −359

Conversation

carlory
Copy link
Member

@carlory carlory commented May 19, 2023

What type of PR is this?

/kind cleanup
/kind deprecation

What this PR does / why we need it:

See #118120 (comment)

Which issue(s) this PR fixes:

Fixes #118120

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-controller-manager deprecate `--volume-host-cidr-denylist` and `--volume-host-allow-local-loopback` flags.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2023
@k8s-ci-robot k8s-ci-robot added area/kube-proxy area/kubelet area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 19, 2023
@danwinship
Copy link
Contributor

/approve
for the pkg/proxy/util parts. But I don't know if this is the path sig-storage wants; discussion on #118120 was not resolved

@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 19, 2023
@carlory carlory force-pushed the fix-issue-118120 branch 2 times, most recently from 7605af7 to 4a688ab Compare May 20, 2023 16:10
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 20, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@carlory
Copy link
Member Author

carlory commented May 20, 2023

/test pull-kubernetes-conformance-kind-ipv6-parallel

@carlory
Copy link
Member Author

carlory commented May 22, 2023

/cc @mattcary @msau42

@carlory
Copy link
Member Author

carlory commented Jun 12, 2023

/assign @thockin

thockin
thockin reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, danwinship, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@thockin
Copy link
Member

thockin commented Jun 12, 2023

@danwinship - one more reason to move pkg/proxy under cmd/kube-proxy and/or staging/src/k8s.io/kube-proxy :)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 12, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 13, 2023
@carlory
Copy link
Member Author

carlory commented Jun 13, 2023

/retest-required

@carlory
Copy link
Member Author

carlory commented Jun 13, 2023

/test pull-kubernetes-e2e-gce-storage-snapshot

@carlory
Copy link
Member Author

carlory commented Jun 13, 2023

/cc @mattcary @thockin

@pacoxu
Copy link
Member

pacoxu commented Jun 14, 2023 •
edited

The rebased LGTM
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 297ab9153047792aeb1ba9a18a8dd9dacc26af2e

@k8s-ci-robot k8s-ci-robot merged commit 173a473 into kubernetes:master Jun 14, 2023
17 checks passed
SIG Node CI/Test Board automation moved this from Archive-it to Done Jun 14, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 14, 2023
@danwinship danwinship mentioned this pull request Feb 20, 2024
Merged
@carlory carlory mentioned this pull request Mar 21, 2024
Merged
@sveinpj sveinpj mentioned this pull request Apr 26, 2024
Closed
5 tasks
@sveinpj sveinpj mentioned this pull request May 30, 2024
Open
5 tasks
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@mattcary mattcary Awaiting requested review from mattcary

@msau42 msau42 Awaiting requested review from msau42

@danwinship danwinship Awaiting requested review from danwinship

@thockin thockin Awaiting requested review from thockin

Assignees

@danwinship danwinship

@pacoxu pacoxu

@thockin thockin

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kube-proxy area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

helper function for unused storage feature in pkg/proxy/util
9 participants
@carlory @danwinship @k8s-triage-robot @cici37 @bart0sh @mattcary @k8s-ci-robot @thockin @pacoxu