Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-proxy: remove log warning about not using config file #118115

Merged
merged 1 commit into from
Jun 8, 2023
Merged

kube-proxy: remove log warning about not using config file #118115

merged 1 commit into from
Jun 8, 2023

Conversation

TommyStarK
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will remove the log warning about not using kube-proxy config file

Which issue(s) this PR fixes:

Fixes #118090

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-proxy: remove log warning about not using config file

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 18, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 18, 2023
@k8s-ci-robot k8s-ci-robot added area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2023
@TommyStarK
Copy link
Contributor Author

/retest-required

@shaneutt
Copy link
Member

/cc @danwinship @shaneutt

@danwinship
Copy link
Contributor

/lgtm
/assign @thockin
for final approval; Jordan pointed out in #117800 (comment) that we should not be trying to force people into using a v1alpha1 config file.

#117909 could evolve into a "figure out a v1beta1 config file" issue...

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 88cbc7db91db37f629e3fa8aeabc7cfbeb7937fd

thockin
thockin reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2023
@thockin
Copy link
Member

thockin commented Jun 8, 2023

@danwinship you should be able to approve this, right? You are in sig-network-approvers

@k8s-ci-robot k8s-ci-robot merged commit de7360d into kubernetes:master Jun 8, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 8, 2023
@TommyStarK TommyStarK deleted the gh_118090 branch June 9, 2023 07:24
@danwinship
Copy link
Contributor

danwinship commented Jun 9, 2023 •
edited

@danwinship you should be able to approve this, right? You are in sig-network-approvers

@thockin yes, just wanted more eyes on it. We had intentionally added that warning at one point; I wanted to make sure you were OK with removing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@thockin thockin thockin left review comments

@cyclinder cyclinder cyclinder left review comments

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

@freehan freehan Awaiting requested review from freehan

@shaneutt shaneutt Awaiting requested review from shaneutt

Assignees

@danwinship danwinship

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

kube-proxy: remove log warning about not using config file
6 participants
@TommyStarK @k8s-ci-robot @shaneutt @danwinship @thockin @cyclinder