-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export DefaultServerUrlFor utility function #118055
Export DefaultServerUrlFor utility function #118055
Conversation
Signed-off-by: Timo Furrer <[email protected]>
Welcome @timofurrer! |
Hi @timofurrer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/ok-to-test /assign @deads2k |
LGTM label has been added. Git tree hash: d7b43ff457e28fc5768db02982215a574f108e37
|
/approve happy to land this PR for exporting a useful function |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, mimani68, timofurrer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
What this PR does / why we need it:
This PR exposes the
DefaultServerUrlFor
utility function - it's a convenient function and we rely on a copy of it to easily get the server url based on a rest config.Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: