Preserve code blocks in templates.Normalizer #118029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if templates.LongDesc function is invoked multiple times for a string including a code block, this code block is converted to invalid code block. The reason of this issue is that blackfriday package, which templates package uses, relies on 4 * indentation to detect code blocks. This PR always preserves 4 * indentation in code blocks to always detect it code blocks in also post invocations.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/triage accepted |
|
/test pull-kubernetes-conformance-kind-ga-only-parallel |
|
@pacoxu would you mind taking a look at this fix?. Does it make sense?. Thanks. |
mpuckett159
reviewed
May 23, 2023
|
/lgtm |
|
LGTM label has been added. Git tree hash: 43fadb6863d5708090c772ece06f53c1f93103ca
|
|
/label tide/merge-method-squash |
|
/hold cancel |
rayowang
pushed a commit
to rayowang/kubernetes
that referenced
this pull request
Feb 9, 2024
* Preserve code blocks in templates.Normalizer Currently, if templates.LongDesc function is invoked multiple times for a string including a code block, this code block is converted to invalid code block. The reason of this issue is that blackfriday package, which templates package uses, relies on 4 * indentation to detect code blocks. This PR always preserves 4 * indentation in code blocks to always detect it code blocks in also post invocations. * Add indentations to test for code blocks * Use strings.repeat for repetition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, if templates.LongDesc function is invoked multiple times for a string including a code block, this code block is converted to invalid code block.
The reason of this issue is that blackfriday package, which templates package uses, relies on 4 * indentation to detect code blocks. This PR always preserves 4 * indentation in code blocks to always detect it code blocks in also post invocations.
Which issue(s) this PR fixes:
Fixes #118028
Special notes for your reviewer:
/assign @pacoxu
Does this PR introduce a user-facing change?