Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update podFailurePolicy comments #117802

Merged
merged 1 commit into from
May 6, 2023
Merged

Update podFailurePolicy comments #117802

merged 1 commit into from
May 6, 2023

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented May 5, 2023 •
edited

What type of PR is this?

/kind cleanup
/sig apps

What this PR does / why we need it:

podFailurePolicy is beta now.
cc @mimowo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Revised the comment about the feature-gate level for PodFailurePolicy from alpha to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation labels May 5, 2023
@kerthcet kerthcet mentioned this pull request May 5, 2023
Merged
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 5, 2023
mimowo
mimowo reviewed May 5, 2023
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing!

staging/src/k8s.io/api/batch/v1/types.go Outdated Show resolved Hide resolved
@mimowo
Copy link
Contributor

mimowo commented May 5, 2023

We will need to cherry-pick this fix to 1.26 & 1.27. Also add a release notes. Maybe
"Fix the mention of the graduation status (from alpha to beta) for the podFailurePolicy field in its documentation."

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@kerthcet kerthcet force-pushed the cleanup/update-PodFailurePolicy-field branch from 0684fdb to c3e77bf Compare May 5, 2023 13:23
@mimowo
Copy link
Contributor

mimowo commented May 5, 2023

/lgtm
I think field documentation is user-facing so it deserves a release note.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e39e39fedfa49ace6343e3db8384cbb68ba9ec64

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 5, 2023
@kerthcet
Copy link
Member Author

kerthcet commented May 5, 2023

We will need to cherry-pick this fix to 1.26 & 1.27. Also add a release notes. Maybe "Fix the mention of the graduation status (from alpha to beta) for the podFailurePolicy field in its documentation."

Do we? It's not a critical bugfix according to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks.

Release note added.

@kerthcet
Copy link
Member Author

kerthcet commented May 5, 2023

/remove-api machinery
/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label May 5, 2023
@mimowo
Copy link
Contributor

mimowo commented May 5, 2023

We will need to cherry-pick this fix to 1.26 & 1.27. Also add a release notes. Maybe "Fix the mention of the graduation status (from alpha to beta) for the podFailurePolicy field in its documentation."

Do we? It's not a critical bugfix according to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks.

Indeed, it isn't critical, but the scope is minimal, the risk is near-zero, and it may avoid user confusion.

Let's see what others think.

@alculquicondor
Copy link
Member

We should cherry-pick, as it can cause confusion.

/lgtm
/approve
/label api-review

This was referenced May 5, 2023
Merged
Merged
@kerthcet
Copy link
Member Author

kerthcet commented May 5, 2023

cherry picked.

@alculquicondor
Copy link
Member

Thanks!

@dims
Copy link
Member

dims commented May 6, 2023

/assign @liggitt

(for api-review, just comments were updated!)

@liggitt
Copy link
Member

liggitt commented May 6, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6aa68d6 into kubernetes:master May 6, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 6, 2023
@kerthcet kerthcet deleted the cleanup/update-PodFailurePolicy-field branch May 7, 2023 01:47
@cici37
Copy link
Contributor

cici37 commented May 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2023
k8s-ci-robot added a commit that referenced this pull request May 11, 2023
@k8s-ci-robot
Merge pull request #117814 from kerthcet/automated-cherry-pick-of-#11…
2f41a33 
…7802-upstream-release-1.26

Automated cherry pick of #117802: Update podFailurePolicy comments from alpha-level to beta
k8s-ci-robot added a commit that referenced this pull request May 11, 2023
@k8s-ci-robot
Merge pull request #117815 from kerthcet/automated-cherry-pick-of-#11…
4c39cdc 
…7802-upstream-release-1.27

Automated cherry pick of #117802: Update podFailurePolicy comments from alpha-level to beta
@mimowo mimowo mentioned this pull request May 26, 2023
Merged
This was referenced Jul 20, 2023
Merged
Closed
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@sttts sttts Awaiting requested review from sttts

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@mimowo mimowo

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kerthcet @mimowo @k8s-triage-robot @k8s-ci-robot @alculquicondor @dims @liggitt @cici37