Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote ProxyTerminatingEndpoints to GA #117718

Merged
merged 2 commits into from
May 4, 2023
Merged

promote ProxyTerminatingEndpoints to GA #117718

merged 2 commits into from
May 4, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented May 2, 2023

/kind feature

kube-proxy handles Terminating EndpointSlices conditions and enables zero downtime deployments for Services with ExternalTrafficPolicy=Local author: @andrewsykim 

- [KEP]: https://github.com/kubernetes/enhancements/issues/1669
- [Usage]: https://kubernetes.io/blog/2022/12/30/advancements-in-kubernetes-traffic-engineering/
- [Example1]: https://gist.github.com/aojea/84fc66fde269f8aef1a4932d074285db
- [Example2]: https://gist.github.com/aojea/cd72e17b7238114a35cb9c82bf2324cb

There are also e2e test with loadbalancers and deployments performing rolling updates

https://testgrid.k8s.io/google-gce#gci-gce-ingress&include-filter-by-regex=should%20not%20have%20connectivity%20disruption%20during%20rolling%20update%20with%20externalTrafficPolicy

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 2, 2023
@aojea
Copy link
Member Author

aojea commented May 2, 2023

/assign @thockin @andrewsykim

The next step is to promote some test to conformance, but it has to demonstrate they are stable for more than 1 week

@k8s-ci-robot k8s-ci-robot added area/kube-proxy area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2023
@aojea
Copy link
Member Author

aojea commented May 2, 2023

/sig network

@aojea
promote ProxyTerminatingEndpoints to GA
791573d 
Change-Id: Ife524c831d905acbc606aa7631e1194f91199938
@aojea aojea force-pushed the ProxyTerminatingEndpoints branch from f332c7e to 791573d Compare May 4, 2023 12:58
@aojea
e2e reasonable grace termination period timeout
b849ff5 
The existing termination period of 600 seconds for pods on the
e2e test causes that those pods are kept running after the
test has finished. 100 seconds is a good compromise to avoid
leaving pods lingering and more than enought for the test to finish.

Change-Id: I993162a77125345df1829044dc2514e03b13a407
@aojea
Copy link
Member Author

aojea commented May 4, 2023

unrelated

TestFormat

/test pull-kubernetes-unit

run it again

/test pull-kubernetes-e2e-gce

thockin
thockin reviewed May 4, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 33a65a4313bf5eca361229ee19a434227a8a8197

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@aojea
Copy link
Member Author

aojea commented May 4, 2023

: [It] [sig-network] LoadBalancers should be able to preserve UDP traffic when server pod cycles for a LoadBalancer service on the same nodes

unrelated, but why is this test running here?
/test pull-kubernetes-e2e-gce

@aojea aojea mentioned this pull request May 4, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 7dec98c into kubernetes:master May 4, 2023
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 4, 2023
@BenTheElder
Copy link
Member

Is this related to #117824 ?

@aojea
Copy link
Member Author

aojea commented May 6, 2023

Is this related to #117824 ?

it just removed the feature tag from the test name so the test started to be exercised on all jobs

@Atharva-Shinde Atharva-Shinde mentioned this pull request Jul 19, 2023
Closed
@aojea aojea mentioned this pull request Jul 26, 2023
Merged
@johngmyers johngmyers mentioned this pull request Aug 8, 2023
Open
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@danwinship danwinship Awaiting requested review from danwinship

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@thockin thockin

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs area/kube-proxy area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aojea @k8s-ci-robot @BenTheElder @thockin @andrewsykim