Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3325: Promote SelfSubjectReview to GA #117713

Merged
merged 3 commits into from
May 3, 2023
Merged

KEP-3325: Promote SelfSubjectReview to GA #117713

merged 3 commits into from
May 3, 2023

Conversation

nabokihms
Copy link
Member

@nabokihms nabokihms commented May 1, 2023 •
edited by liggitt

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Which issue(s) this PR fixes:

This PR is a part of kubernetes/enhancements#3325

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The `SelfSubjectReview` API is promoted to `authentication.k8s.io/v1` and the `kubectl auth whoami` command is GA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 1, 2023
@nabokihms nabokihms mentioned this pull request May 1, 2023
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added area/code-generation area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 1, 2023
@nabokihms
Copy link
Member Author

/ok-to-test
/test all

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 1, 2023
@nabokihms
Copy link
Member Author

/assign liggitt

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 2, 2023
@nabokihms
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot requested review from aojea and deads2k May 2, 2023 21:11
@liggitt
Copy link
Member

liggitt commented May 2, 2023 •
edited

since this is promoting an API to v1 without requiring it to be in conformance, this should add to test/conformance/testdata/ineligible_endpoints.yaml to avoid an apparent regression in endpoint coverage

- endpoint: createAuthenticationV1SelfSubjectReview
  reason: Cluster providers are allowed to choose to not serve this API, and the whoami command handles unavailability gracefully.
  link: https://github.com/kubernetes/enhancements/blob/master/keps/sig-auth/3325-self-subject-attributes-review-api/README.md#ga

liggitt
liggitt reviewed May 2, 2023
View reviewed changes
test/e2e/auth/selfsubjectreviews.go
@@ -22,6 +22,7 @@ import (

"github.com/onsi/ginkgo/v2"
"github.com/onsi/gomega"
authenticationv1 "k8s.io/api/authentication/v1"
authenticationv1alpha1 "k8s.io/api/authentication/v1alpha1"
authenticationv1beta1 "k8s.io/api/authentication/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the e2e test should drop the [Feature:APISelfSubjectReview] tag so it actually runs in the main e2e job (and may need to make the alpha/beta portions conditional on availability of those APIs)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To not forget: also required to delete it from the list here https://github.com/kubernetes/test-infra/blob/a66784ee843eeaa97a7a13b756301d1e9a2c91ab/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml#L363

liggitt
liggitt reviewed May 2, 2023
View reviewed changes
test/cmd/auth_whoami.sh Outdated Show resolved Hide resolved
@liggitt liggitt added this to API review completed, 1.28 in API Reviews May 2, 2023
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels May 2, 2023
@nabokihms
Copy link
Member Author

/retest

1 similar comment
@nabokihms
Copy link
Member Author

/retest

@nabokihms nabokihms requested a review from liggitt May 3, 2023 10:03
@liggitt
Copy link
Member

liggitt commented May 3, 2023

/lgtm
/approve

/assign @dims
for conformance file touch

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0dcc28f47993120721468993969a9eff6975f922

@liggitt
Copy link
Member

liggitt commented May 3, 2023

@nabokihms thanks, lgtm. Go ahead and queue up the doc PR to update examples/feature state/feature gate docs/etc in dev-1.28 if you are able

@dims
Copy link
Member

dims commented May 3, 2023

/approve

(conformance related updates)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, nabokihms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@nabokihms
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 78833e1 into kubernetes:master May 3, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 3, 2023
@nabokihms nabokihms mentioned this pull request May 4, 2023
Merged
3 tasks
@cici37
Copy link
Contributor

cici37 commented May 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2023
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpursley brianpursley Awaiting requested review from brianpursley

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@aojea aojea Awaiting requested review from aojea

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/conformance Issues or PRs related to kubernetes conformance tests area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.28
SIG Auth
Archived in project
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nabokihms @k8s-ci-robot @liggitt @dims @cici37