Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: bump k8s.io/utils #117139

Merged
merged 1 commit into from
May 15, 2023
Merged

dependencies: bump k8s.io/utils #117139

merged 1 commit into from
May 15, 2023
+110 −91

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 6, 2023 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

This includes a fix for a race condition.

Does this PR introduce a user-facing change?

Recording timing traces had a race condition. Impact in practice was probably low.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Apr 6, 2023
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.27 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.27.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Apr 6 07:59:36 UTC 2023.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 6, 2023
@pohly pohly mentioned this pull request Apr 6, 2023
Merged
@k8s-ci-robot k8s-ci-robot requested review from andrewsykim, andyzhangx and a team April 6, 2023 11:14
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2023
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Apr 6, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Apr 6, 2023

/triage accepted
/priority important-longterm
/retest
/assign

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Apr 6, 2023
@logicalhan
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2023
@bart0sh bart0sh moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Apr 25, 2023
@jingxu97
Copy link
Contributor

@pohly there is a merge conflict.

@pohly
dependencies: bump k8s.io/utils
83fb5a5 
This includes a fix for a race condition.
@pohly pohly force-pushed the test-integration-race-detection-update-utils branch from 1303611 to 83fb5a5 Compare May 15, 2023 06:58
@k8s-ci-robot k8s-ci-robot added area/kube-proxy sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 15, 2023
@pohly
Copy link
Contributor Author

pohly commented May 15, 2023

/assign @dims

@k8s-ci-robot
Copy link
Contributor

@pohly: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-kind-dra 83fb5a5 link false /test pull-kubernetes-kind-dra

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bart0sh
Copy link
Contributor

bart0sh commented May 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d52340196561a76c68f453b79089b39ba26c1d0c

@dims
Copy link
Member

dims commented May 15, 2023

/approve

@pohly
Copy link
Contributor Author

pohly commented May 15, 2023

/assign @liggitt

For dep approval in staging/src/k8s.io/api.

@pohly
Copy link
Contributor Author

pohly commented May 15, 2023

pull-kubernetes-kind-dra failing is a known, unrelated issue.

@liggitt
Copy link
Member

liggitt commented May 15, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@dims
Copy link
Member

dims commented May 15, 2023

/skip

(unrelated failure)

@k8s-ci-robot k8s-ci-robot merged commit 87d8c4e into kubernetes:master May 15, 2023
15 checks passed
SIG Node PR Triage automation moved this from Waiting on Author to Done May 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 15, 2023
@bart0sh bart0sh mentioned this pull request May 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@dims dims

@liggitt liggitt

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@pohly @k8s-ci-robot @bart0sh @logicalhan @jingxu97 @dims @liggitt