-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure version "*" is passed instead of "" for all authz checks #116937
Conversation
Please note that we're already in Test Freeze for the Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Mar 27 04:26:09 UTC 2023. |
/triage accepted |
/lgtm |
LGTM label has been added. Git tree hash: b10d46646e388c09c5605c29764da9c6f5ca899c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AxeZhan, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rnetes#116937) * ensure version * is passed instead of for all authz checks * unexport match function * remove allversion constant
What type of PR is this?
/kind feature
What this PR does / why we need it:
SubjectAccessReview expects "*" (not "") if the version is unspecified.
This pr audit all authz checks to ensure that "*" is being passed everywhere.
Which issue(s) this PR fixes:
Fixes #115660
Special notes for your reviewer:
I'm not familiar with the codes in auth part. So if I'm missing something, plz give me a hint and I will dig into it.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: