Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated pkg/controller/endpoint to contextual logging #116755

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Migrated pkg/controller/endpoint to contextual logging #116755

merged 1 commit into from
Jul 10, 2023

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented Mar 20, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref kubernetes/enhancements#3077

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate `pkg/controller/endpoint` to contextual logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2023
@my-git9 my-git9 force-pushed the feat/endpoint/logging branch 2 times, most recently from 54ce67d to fe9ec84 Compare March 20, 2023 16:11
@my-git9 my-git9 changed the title Migrated pkg/controller/endpoint to contextual logging Migrated pkg/controller/endpoint to contextual logging Mar 20, 2023
@my-git9
Copy link
Member Author

my-git9 commented Mar 20, 2023

/test pull-kubernetes-e2e-kind-ipv6

@my-git9
Copy link
Member Author

my-git9 commented Mar 21, 2023

/assign @pohly

pohly
pohly suggested changes Apr 11, 2023
View reviewed changes
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
pkg/controller/endpoint/endpoints_controller.go Outdated Show resolved Hide resolved
@my-git9 my-git9 requested a review from pohly April 11, 2023 12:09
@my-git9
Copy link
Member Author

my-git9 commented Apr 11, 2023

/test pull-kubernetes-conformance-kind-ga-only-parallel

@my-git9
Copy link
Member Author

my-git9 commented Apr 11, 2023

/test pull-kubernetes-e2e-gce

pohly
pohly suggested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done 😄

Can you also remove the exception from

kubernetes/hack/logcheck.conf

Line 45 in 5f23f83

-contextual k8s.io/kubernetes/pkg/controller/endpoint/.*

@pohly pohly mentioned this pull request Apr 12, 2023
Open
12 tasks
@my-git9 my-git9 requested a review from pohly April 12, 2023 08:12
@my-git9
Copy link
Member Author

my-git9 commented Apr 12, 2023

Almost done 😄

Can you also remove the exception from

kubernetes/hack/logcheck.conf

Line 45 in 5f23f83

-contextual k8s.io/kubernetes/pkg/controller/endpoint/.*

Updated, thanks for your review

pohly
pohly approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @soltysh

For approval.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@pohly pohly mentioned this pull request May 23, 2023
Merged
@mengjiao-liu
Copy link
Member

/sig instrumentation
/wg structured-logging
/area logging

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging labels Jul 10, 2023
@mengjiao-liu
Copy link
Member

ping @soltysh

pohly
pohly approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92d8e3fb559558b7af893c10c83f35b99e76ada4

soltysh
soltysh approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@soltysh
Copy link
Contributor

soltysh commented Jul 10, 2023

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: my-git9, pohly, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 10a1216 into kubernetes:master Jul 10, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 10, 2023
@mengjiao-liu mengjiao-liu mentioned this pull request Jul 11, 2023
Merged
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly approved these changes

@soltysh soltysh soltysh approved these changes

@aojea aojea Awaiting requested review from aojea

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@pohly pohly

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@my-git9 @mengjiao-liu @k8s-ci-robot @soltysh @pohly