Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote ExpandedDNSConfig feature to the GA stage #116741

Merged
merged 1 commit into from
May 31, 2023
Merged

Promote ExpandedDNSConfig feature to the GA stage #116741

merged 1 commit into from
May 31, 2023
+42 −502

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Mar 19, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This promotes the ExpandedDNSConfig feature to the GA stage.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The `ExpandedDNSConfig` feature has graduated to GA. 'ExpandedDNSConfig' feature was locked to default value and will be removed in v1.30. If you were setting this feature gate explicitly, please remove it now.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2595-expanded-dns-config

/uncc all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 19, 2023
@bart0sh bart0sh moved this from Triage to WIP in SIG Node PR Triage Mar 30, 2023
@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-ga branch from f55fdc2 to 7ce60a4 Compare April 11, 2023 12:56
@gjkim42 gjkim42 changed the title WIP: Promote ExpandedDNSConfig feature to the GA stage Promote ExpandedDNSConfig feature to the GA stage Apr 11, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@gjkim42 gjkim42 moved this from WIP to Needs Reviewer in SIG Node PR Triage Apr 11, 2023
@gjkim42 gjkim42 changed the title Promote ExpandedDNSConfig feature to the GA stage WIP: Promote ExpandedDNSConfig feature to the GA stage Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2023
@gjkim42 gjkim42 moved this from Needs Reviewer to WIP in SIG Node PR Triage Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 11, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Apr 11, 2023

/priority important-soon
/kind feature

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 11, 2023
@aojea
Copy link
Member

aojea commented Apr 11, 2023

you first lock the feature gate to GA, and after two releases you can safely remove the code

kubernetes/pkg/features/kube_features.go

Line 955 in ad18954

CSIMigrationAzureFile: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // remove in 1.28

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a6b2f06c86352b50303eda015315e0be635c46f

thockin
thockin reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Apr 14, 2023 •
edited

/hold
as KEP pr has not been merged yet.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@gjkim42 gjkim42 force-pushed the promote-expanded-dns-config-to-ga branch from 7ce60a4 to b249b4c Compare May 4, 2023 11:37
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented May 4, 2023

/retest

1 similar comment
@bart0sh
Copy link
Contributor

bart0sh commented May 4, 2023

/retest

thockin
thockin reviewed May 30, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb9cb37f9ea8594da0e5ca487e7ac410fb326542

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, gjkim42, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gjkim42
Copy link
Member Author

gjkim42 commented May 31, 2023

/unhold
as kubernetes/enhancements#3914 has been merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0bb17a8 into kubernetes:master May 31, 2023
13 checks passed
SIG Node PR Triage automation moved this from Needs Reviewer to Done May 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 31, 2023
@gjkim42 gjkim42 deleted the promote-expanded-dns-config-to-ga branch May 31, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@thockin thockin thockin left review comments

@mikebrow mikebrow Awaiting requested review from mikebrow

@mrunalp mrunalp Awaiting requested review from mrunalp

@aojea aojea Awaiting requested review from aojea

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@thockin thockin

@derekwaynecarr derekwaynecarr

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@gjkim42 @aojea @bart0sh @k8s-ci-robot @liggitt @thockin @mrunalp @derekwaynecarr @SergeyKanzhelev