Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate ReportingInstance and ReportingController in Event #116506

Merged
merged 1 commit into from
May 9, 2023
Merged

generate ReportingInstance and ReportingController in Event #116506

merged 1 commit into from
May 9, 2023

Conversation

HirazawaUi
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

the reportingController and reportingInstance fields in the event do not have values, which is non-compliant with the Kubernetes API v1.25 specification. Further details can be found at https://kubernetes.io/docs/reference/using-api/deprecation-guide/#event-v125

Which issue(s) this PR fixes:

Fixes #116444

Special notes for your reviewer:

Does this PR introduce a user-facing change?

When retrieving event resources, the reportingController and reportingInstance fields in the event will contain values.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @HirazawaUi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 12, 2023
@wanlonghenry
Copy link

wanlonghenry commented Mar 14, 2023 •
edited

https://kubernetes.io/docs/reference/using-api/deprecation-guide/ The deprecation guide also mentioned the renames. Should that be fixed as well for now or we want to keep them that way? And if we want to keep them that way, doc also needs to be updated.

@cici37
Copy link
Contributor

cici37 commented Mar 16, 2023

/sig instrumentation
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 16, 2023
logicalhan
logicalhan approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc057d9bddf7e761b40a6be42fa27245963363d6

@logicalhan
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 23, 2023
@HirazawaUi
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HirazawaUi
Copy link
Contributor Author

@logicalhan could you please help me retest

@dgrisonnet
Copy link
Member

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 27, 2023
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

1 similar comment
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 27, 2023
@HirazawaUi
Copy link
Contributor Author

/retest

2 similar comments
@HirazawaUi
Copy link
Contributor Author

/retest

@HirazawaUi
Copy link
Contributor Author

/retest

@HirazawaUi
Copy link
Contributor Author

HirazawaUi commented Apr 22, 2023 •
edited

@logicalhan May you help this PR to LGTM again?

@HirazawaUi
Copy link
Contributor Author

@dgrisonnet @dashpole @logicalhan Can we continue reviewing this PR?

logicalhan
logicalhan approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(from sig inst)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a86af5c859e996ed6ecf249b55ade3b341f5d0b2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HirazawaUi, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b277afd into kubernetes:master May 9, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 9, 2023
@aritraghosh
Copy link

Will this be backported to prior Kubernetes versions before 1.28?

@HirazawaUi
Copy link
Contributor Author

Will this be backported to prior Kubernetes versions before 1.28?

as it should be

This was referenced Aug 19, 2023
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 28, 2023
@k8s-ci-robot
Merge pull request #120067 from HirazawaUi/automated-cherry-pick-of-#…
350fe26 
…116506-upstream-release-1.27

Automated cherry pick of #116506: generate ReportingInstance and ReportingController in Event
k8s-ci-robot added a commit that referenced this pull request Aug 28, 2023
@k8s-ci-robot
Merge pull request #120065 from HirazawaUi/automated-cherry-pick-of-#…
3f833a4 
…116506-upstream-release-1.25

Automated cherry pick of #116506: generate ReportingInstance and ReportingController in Event
k8s-ci-robot added a commit that referenced this pull request Aug 28, 2023
@k8s-ci-robot
Merge pull request #120066 from HirazawaUi/automated-cherry-pick-of-#…
dbe3960 
…116506-upstream-release-1.26

Automated cherry pick of #116506: generate ReportingInstance and ReportingController in Event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan approved these changes

@dashpole dashpole Awaiting requested review from dashpole

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

events.k8s.io/v1 api does not have changes in place mentioned in the Deprecated API Migration Guide
8 participants
@HirazawaUi @k8s-ci-robot @wanlonghenry @cici37 @logicalhan @dgrisonnet @k8s-triage-robot @aritraghosh