Cache authz decisions within the scope of validating policy admission. #116443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benluddy: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/triage accepted |
cd07895
to
7cb063c
Compare
7cb063c
to
c72b2cf
Compare
c72b2cf
to
5c6fb31
Compare
|
/cc @alexzielenski Do you have bandwidth for a review pass? |
alexzielenski
suggested changes
Jun 28, 2023
...ng/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/caching_authorizer.go
Outdated
Show resolved
Hide resolved
| @@ -3022,3 +3027,167 @@ func toHasLengthOf(n int) func(warnings []admissionregistrationv1alpha1.Expressi | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| func TestAuthorizationDecisionCaching(t *testing.T) { | |||
5c6fb31
to
520c173
Compare
benluddy
commented
Jun 28, 2023
...ng/src/k8s.io/apiserver/pkg/admission/plugin/validatingadmissionpolicy/caching_authorizer.go
Show resolved
Hide resolved
This avoids the surprise of identical authorization checks within a policy evaluating to different decisions during the same admission pass, and reduces the overhead of repeatedly referencing the same authorization check.
520c173
to
f1700e4
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 004e2499d5691592b8ea39d486c8110de7481bd5
|
|
/assign @jpbetz @alexzielenski Thanks for the speedy review. Can you approve on behalf of |
|
/approve I appreciate the high quality test coverage here, it gave me added confidence that this is working as intended. |
jpbetz
approved these changes
Jul 11, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexzielenski, benluddy, jpbetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Identical checks should produce identical decisions when referenced more than once in a policy expression, or by more than one expression in a policy.
#116054 (comment)
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: