Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about TLS 1.3 cipher suites #115399

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Add note about TLS 1.3 cipher suites #115399

merged 3 commits into from
Apr 11, 2023

Conversation

3u13r
Copy link
Contributor

@3u13r 3u13r commented Jan 30, 2023 •
edited

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Document that a user configuration is ignored for TLS 1.3.
This aligns the documentation with Go's tls package.

The goal is to avoid misconfigurations, where the user thinks they are restricting/selecting TLS 1.3 ciphers.
While changing the TLS 1.3 ciphers is a non-goal in itself, I think the diverging behavior should be documented.

EDIT:
To clarify, Kubernetes passes the minimum TLS version and configured cipher suites into Go's tls.Config struct.
There it is stated that any cipher suite configuration regarding TLS 1.3 is ignored.
Therefore, Kubernetes also ignores any attempt to configure TLS 1.3 cipher suites.
This PR documents TLS 1.3 as an exception for TLSCipherSuites documented behavior.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added a warning that TLS 1.3 ciphers are not configurable.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 30, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 30, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @3u13r!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @3u13r. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 30, 2023
@k8s-ci-robot k8s-ci-robot added area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 30, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@cici37
Copy link
Contributor

cici37 commented Jan 31, 2023

/remove-sig api-machinery
/api-review

@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 31, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 31, 2023

/assign @kubernetes/api-reviewers

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 2, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 7, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2023

@3u13r This seems to be a user-visible change. Please, update release notes, thanks.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2023

@3u13r please fix CI test failures, thanks.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2023

/assign

@bart0sh
Copy link
Contributor

bart0sh commented Feb 7, 2023

@3u13r can you provide more details in the description. It's not clear to me why we need to ignore TLS 1.3 configuration.

@bart0sh bart0sh moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2023
@3u13r
Copy link
Contributor Author

3u13r commented Mar 14, 2023 •
edited

I'm sorry that I've missed the release note. I've also added more information in the PR description. In short: Kubernetes correctly passes all TLS configuration to Go's tls library. But the library ignores the cipher suite selection for TLS 1.3.
ping @bart0sh: Are there any open questions right now?

@3u13r 3u13r requested review from liggitt and removed request for sttts March 20, 2023 21:01
@bart0sh bart0sh moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Mar 30, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Mar 30, 2023

/lgtm
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c6bafa197f65ceb105084c910fead6ab02c6893

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 30, 2023
@liggitt
Copy link
Member

liggitt commented Mar 30, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3u13r, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2023
@Adeccer

This comment was marked as off-topic.

Sign in to view
@k8s-ci-robot k8s-ci-robot merged commit 779abe6 into kubernetes:master Apr 11, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Apr 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 11, 2023
@jaskaransarkaria jaskaransarkaria mentioned this pull request Jun 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@3u13r @k8s-ci-robot @k8s-triage-robot @cici37 @bart0sh @liggitt @Adeccer @SergeyKanzhelev