Migrated pkg/controller/endpointslice and pkg/controller/endpointslicemirroring to contextual logging
#115295
Conversation
|
/remove-sig api-machinery |
|
@Namanl2001: ping. Can you address the pending comments? |
|
@Namanl2001 : please check and fix the errors in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/115295/pull-kubernetes-verify/1626651996108886016 |
|
@Namanl2001: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-verify |
|
@Namanl2001: can you run |
locally this command is only running for the |
|
You might have a conflict with master: your changes get merged with master and then tested. Try rebasing onto master and then run |
No. Do the same as in other PRs (for example, #119147) and pass in a logger that then gets used by those informer callbacks. |
|
More specifically, use this pattern: podInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{
AddFunc: func(obj interface{}) {
dc.addPod(logger, obj)
},
UpdateFunc: func(oldObj, newObj interface{}) {
dc.updatePod(logger, oldObj, newObj)
},
DeleteFunc: func(obj interface{}) {
dc.deletePod(logger, obj)
},
}) |
d3571c0
to
24630a2
Compare
|
@Namanl2001: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Please squash as part of your next push. This PR will conflict with #114982. Let's merge both through this PR here, i.e. add a second commit with the changes from 114982. |
Signed-off-by: Naman <[email protected]>
Signed-off-by: Naman <[email protected]>
24630a2
to
645cb90
Compare
pkg/controller/endpointslice to contextual loggingpkg/controller/endpointslice and pkg/controller/endpointslicemirroring to contextual logging
|
/release-note-edit |
Please check if it looks good now |
|
LGTM label has been added. Git tree hash: 05498c24bde4c2cb561e8ac23fde1a4917d42993
|
|
/assign @soltysh For approval. |
|
/priority important-longterm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Namanl2001, pohly, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Naman [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
Convert EndpointSlice functions to structured logging when context parameter is not available, otherwise, convert to contextual logging
Which issue(s) this PR fixes:
Part of kubernetes/enhancements#3077
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/wg structured-logging
/area logging
/assign @pohly