Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove GA feature-gate for 1.28 #114068

Merged
merged 1 commit into from
Apr 20, 2023
Merged

remove GA feature-gate for 1.28 #114068

merged 1 commit into from
Apr 20, 2023

Conversation

cyclinder
Copy link
Contributor

@cyclinder cyclinder commented Nov 22, 2022 •
edited by k8s-ci-robot

Signed-off-by: cyclinder [email protected]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove GA feature-gate for 1.26

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The feature gates `DisableAcceleratorUsageMetrics` and `PodSecurity` that graduated to GA and were unconditionally enabled have been removed in v1.28

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 22, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Nov 22 09:29:40 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet labels Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 22, 2022
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Nov 22, 2022
@cyclinder
Copy link
Contributor Author

/release-note-label none

@cyclinder
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 22, 2022
@cyclinder
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 22, 2022
@aojea
Copy link
Member

aojea commented Nov 22, 2022

is this not out of the release window and should go in 1.27?

@cyclinder
Copy link
Contributor Author

cyclinder commented Nov 22, 2022 •
edited

yeah, it's should appear in 1.27

@cyclinder cyclinder changed the title remove GA feature-gate for 1.26 remove GA feature-gate for 1.27 Nov 23, 2022
@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Nov 29, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Dec 12, 2022

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 13, 2022
@bart0sh bart0sh moved this from Triage to Waiting on Author in SIG Node PR Triage Dec 14, 2022
@pacoxu
Copy link
Member

pacoxu commented Dec 14, 2022

Need rebase after #114410

@pacoxu
Copy link
Member

pacoxu commented Mar 14, 2023

Is this CI flaky related to the changes?

This is a failing test #116515.

@humblec
Copy link
Contributor

humblec commented Mar 14, 2023

Is this CI flaky related to the changes?

This is a failing test #116515.

Should be good with #116578

@liggitt
Copy link
Member

liggitt commented Mar 24, 2023

@msau42 @jsafrane - is it better to put the CSI migration gate removals in a PR that also cleans up the in-tree volume plugins for those types? AWS gate was dropped in #115838 with the accompanying code, and that is a little easier to reason about (the gate went away when the code did)

@msau42
Copy link
Member

msau42 commented Mar 24, 2023

Is it better to put the CSI migration gate removals in a PR that also cleans up the in-tree volume plugins for those types?

I agree it makes more logical sense to combine them although is not strictly required.

@msau42
Copy link
Member

msau42 commented Mar 24, 2023

Is it better to put the CSI migration gate removals in a PR that also cleans up the in-tree volume plugins for those types?

I agree it makes more logical sense to combine them although is not strictly required.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 3, 2023
@cyclinder cyclinder mentioned this pull request Apr 3, 2023
Merged
@cyclinder
Copy link
Contributor Author

Thanks @liggitt @msau42 .

I opened a pr (#117055) and put the CSI migration gate removals in #117055.

This PR only cleans up these gates: DisableAcceleratorUsageMetrics and PodSecurity. Would you mind taking a review?

@pacoxu
Copy link
Member

pacoxu commented Apr 3, 2023

/retitle remove GA feature-gate for 1.28

@k8s-ci-robot k8s-ci-robot changed the title remove GA feature-gate for 1.27 remove GA feature-gate for 1.28 Apr 3, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 3, 2023 •
edited

@cyclinder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-gce-alpha-features b8624b7d3a9311957864f6907aa511415e13a201 link false /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-ubuntu-containerd b8624b7d3a9311957864f6907aa511415e13a201 link true /test pull-kubernetes-e2e-gce-ubuntu-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cyclinder
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-cos-alpha-features

@liggitt
Copy link
Member

liggitt commented Apr 3, 2023

lgtm for PodSecurity for sig-auth

@dims
Copy link
Member

dims commented Apr 20, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: aaaed097abd6119f4e2f651f63c5bafe54fa63d6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cyclinder, dims, jiahuif, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8d494c4 into kubernetes:master Apr 20, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Apr 20, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 20, 2023
@pacoxu
Copy link
Member

pacoxu commented Apr 25, 2023

/release-note-edit

The feature gates `DisableAcceleratorUsageMetrics` and `PodSecurity` that graduated to GA and were unconditionally enabled have been removed in v1.28

This was referenced Aug 25, 2023
Merged
Merged
@dmyar21 dmyar21 mentioned this pull request Sep 6, 2023
Merged
5 tasks
@honcao honcao mentioned this pull request Jan 3, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@andyzhangx andyzhangx andyzhangx left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@msau42 msau42 msau42 left review comments

@ffromani ffromani ffromani left review comments

@swatisehgal swatisehgal swatisehgal requested changes

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@dims dims Awaiting requested review from dims

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

@pohly pohly Awaiting requested review from pohly

@bart0sh bart0sh Awaiting requested review from bart0sh

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@jiahuif jiahuif Awaiting requested review from jiahuif

@mrunalp mrunalp Awaiting requested review from mrunalp

@pacoxu pacoxu Awaiting requested review from pacoxu

@torredil torredil Awaiting requested review from torredil

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@dims dims

@mrunalp mrunalp

@xing-yang xing-yang

@pacoxu pacoxu

@jiahuif jiahuif

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet