-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broker class based defaults #7631
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Leo Li <[email protected]>
Skipping CI for Draft Pull Request. |
c4a2ff3
to
662c214
Compare
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7631 +/- ##
==========================================
+ Coverage 67.73% 67.86% +0.12%
==========================================
Files 354 363 +9
Lines 16512 16923 +411
==========================================
+ Hits 11184 11484 +300
- Misses 4639 4733 +94
- Partials 689 706 +17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
This Pull Request is stale because it has been open for 90 days with |
Hey @Leo6Leo anything I can help with on this PR? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Leo6Leo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/remove-lifecycle stale Resume working on the issue |
…ble instead Signed-off-by: Leo Li <[email protected]>
…r has value, it will pass. So this commit fix that problem. Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Currently, the table unit test
Note: this is where clusterReference.Namespace is set. @creydr @pierDipi @Cali0707 Do you guys know how to run the tests in the eventing-rabbitmq repo locally with the changes I have made in this PR? |
Not sure, if there is a simple way, but you can use your branch to eventing-core in eventing-rabbitsmqs go.mod file via a replace directive. E.g. something like this:
and then run |
Signed-off-by: Leo Li <[email protected]>
Signed-off-by: Leo Li <[email protected]>
Steps to test
|
Signed-off-by: Leo Li <[email protected]>
/unhold |
@Leo6Leo is there a plan to add a rekt test for this feature? Maybe in another PR? |
return config, nil | ||
} | ||
|
||
return d.ClusterDefaultConfig.BrokerConfig, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Leo Li <[email protected]>
Fixes #5992
Proposed Changes
Corner cases - what will happen if the user do these:
Pre-review Checklist
Release Note
Docs