Keep releasing executables with legacy names #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
reviewed
Nov 24, 2023
| @@ -369,6 +369,9 @@ jobs: | |||
| TAG_NAME: ${{ github.ref_name }} | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| run: | | |||
| cp jq-linux/{jq-linux-amd64,jq-linux64} | |||
| cp jq-macos/{jq-macos-amd64,jq-osx-amd64} | |||
| cp jq-windows/{jq-windows-amd64.exe,jq-win64.exe} | |||
There was a problem hiding this comment.
Maybe a comment why this is done?
|
The jq-linux64, jq-osx-amd64, and jq-win64.exe binaries for the 1.7 release where added manually? |
wader
approved these changes
Nov 24, 2023
|
It was added manually in 1.7. #2877 (comment) |
emanuele6
approved these changes
Nov 25, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed the executable names with explicit architecture name in the 1.7 release, but users still keep downloading with the legacy URLs (ref: #2877). To avoid the same troubles in the coming patch release, I would like to keep releasing executables with legacy names. Based on the download counts, I restored
jq-linux64,jq-osx-amd64, andjq-win64.exe.