Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the default colors to use 39, the default foreground color #2904

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Fix the default colors to use 39, the default foreground color #2904

merged 3 commits into from
Sep 22, 2023

Conversation

taoky
Copy link
Contributor

@taoky taoky commented Sep 18, 2023

This reverts commit 07b18a3, and fix #2903.

According to Linux manpage console_codes(4), "color 39" is not a undefined value:

39         set default foreground color (before Linux 3.16: set underscore off, set default foreground color)

I'm afraid that what in #2032 does not hold, and setting its value to 37 hurts users with light background, as "color 37" is:

37         set white foreground

@taoky
Copy link
Contributor Author

taoky commented Sep 18, 2023

And according to ECMA standard:

https://www.ecma-international.org/wp-content/uploads/ECMA-48_2nd_edition_august_1979.pdf, page 41 (PDF page 49):

39 (reserved for future standardization)

https://www.ecma-international.org/wp-content/uploads/ECMA-48_3rd_edition_march_1984.pdf, page 46 (PDF page 53), and https://www.ecma-international.org/wp-content/uploads/ECMA-48_5th_edition_june_1991.pdf, page 62 (PDF page 76):

39 default display colour (implementation-defined)

@nicowilliams
Copy link
Contributor

nicowilliams commented Sep 19, 2023 •
edited
Loading

Wouldn't we also need to update the main manual?

Otherwise LGTM.

@itchyny itchyny changed the title Revert "Update other manual and source to use ;37" Fix the default colors to use 39, the default foreground color Sep 22, 2023
@itchyny itchyny merged commit 8f81668 into jqlang:master Sep 22, 2023
29 checks passed
@emanuele6 emanuele6 added the bug label Sep 28, 2023
@emanuele6 emanuele6 mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itchyny itchyny itchyny approved these changes

@nicowilliams nicowilliams Awaiting requested review from nicowilliams

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default color of jq is indistinguishable under Solarized Light background
4 participants
@taoky @nicowilliams @itchyny @emanuele6