clarify filter usage #1944
Merged
clarify filter usage #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current paragraph is not complete, since a digit is not a special character.
Changing it to:
If the key contains special characters or starts with a digit,
you need to surround it with double quotes like this:
`."foo$"`, or else `.["foo$"]`.
|
/ref #1943 |
|
This looks great, thanks! Should we also demonstrate a version like |
|
IMO there's no need, and I wouldn't even know where to add it and how. It would make it more complex and confusing. Since you've already used both forms, you'd have to use both for the 2nd example as well: e.g.: For me this makes it less readable, but maybe that's just me. |
|
@wtlangford is antthing else blocking this from being merged? |
|
Nope, I was just busy. Thanks! |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current paragraph is not complete, since a digit is not a special character.
Changing it to: