Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI does extra work by running sudo apt-get upgrade #3066

Closed
mgree opened this issue Mar 12, 2024 · 2 comments · Fixed by #3082
Closed

CI does extra work by running sudo apt-get upgrade #3066

mgree opened this issue Mar 12, 2024 · 2 comments · Fixed by #3082
Labels
Github Actions

Comments

@mgree
Copy link

mgree commented Mar 12, 2024 •
edited
Loading

The CI workflow file testing the jq build runs sudo apt-get upgrade, which can lead to updating irrelevant packages, like firefox.

EDITED TO ADD: https://github.com/jqlang/jq/actions/runs/8252928583?pr=3063 is a run that exhibits the slow behavior.
@wader
Copy link
Member

wader commented Mar 12, 2024

Yeap that seems unnecessary.

@owenthereal was there some special reasons for doing an upgrade?

@emanuele6
Copy link
Member

emanuele6 commented Mar 28, 2024 •
edited
Loading

FWIW I have had to re-run a lot of CI jobs in the past two/three days because they were randomly failing on that step:
https://github.com/jqlang/jq/actions/runs/8466407678/job/23195111718

wader added a commit to wader/jq that referenced this issue Mar 28, 2024
@wader
ci: Remove unnecessary apt-get upgrade
ce7d67f 
Causes update to irrelevant packages and added flakeyness

Fixes jqlang#3066
@wader wader mentioned this issue Mar 28, 2024
Merged
wader added a commit that referenced this issue Mar 28, 2024
@wader
ci: Remove unnecessary apt-get upgrade (#3082)
afe0afa 
Causes update to irrelevant packages and added flakeyness

Fixes #3066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Remove unnecessary apt-get upgrade wader/jq
3 participants
@wader @mgree @emanuele6