Hey there @Danielhiversen, @felipediel, @L-I-Am, mind taking a look at this pull request as it has been labeled with an integration (broadlink) you are listed as a code owner for? Thanks!

In the tests, consider validating the parameters (hour, minute, day, etc) get passed to the device call correctly. May require mocking dt_util.now().

Also considered this but decided that the simple logic does not warrant such a complex test.

Thanks @eifinger!

Have you thought about using a datetime entity to show/update the date/time?

Thanks @eifinger!

Have you thought about using a datetime entity to show/update the date/time?

I thought about supplying a datetime to the service but could not think of a valid usecase why it would be different from now(). Can you think of a usecase for doing that?

Also nice idea to use a datetime entity for that 👍

Thanks @eifinger!

Have you thought about using a datetime entity to show/update the date/time?

For showing the current time of the device I would need to find out how it works. Moreover I wanted to stay simple.

Thanks @eifinger!
Have you thought about using a datetime entity to show/update the date/time?

For showing the current time of the device I would need to find out how it works. Moreover I wanted to stay simple.

For future reference: https://github.com/mjg59/python-broadlink/blob/66744707f517593de8276ed550cecae31c204c57/broadlink/climate.py#L83-L109

Thanks @eifinger! Here's a datetime implementation for reference. It is straightforward, we basically need:

• a property named native_value that returns the datetime fetched by the update coordinador (in our case it is stored in self._coordinator.data)

    @property
    def native_value(self) -> datetime | None:
        """Return the latest value."""
        if (data := self._coordinator.data) is None:
            return None

        now = dt.now()
        device_weekday = data["dayofweek"] - 1
        this_weekday = now.weekday()

        if device_weekday != this_weekday:
            days_diff = this_weekday - device_weekday
            if days_diff < 0:
                days_diff += 7
            now -= timedelta(days=days_diff)

        return now.replace(
            hour=data["hour"],
            minute=data["min"],
            second=data["sec"],
        )

• a method named async_set_value() that receives a datetime as parameter and sends it to the device

    async def async_set_value(self, value: datetime) -> None:
        """Change the value."""
        await self._device.async_request(
            self._device.api.set_time,
            hour=value.hour,
            minute=value.minute,
            second=value.second,
            day=value.weekday() + 1,
        )

I don't see any practical scenarios beyond exposing the device date/time and adjusting it manually or through automations, but I would still prefer to use the native Home Assistant component. Leveraging native components offers several benefits, such as a user-friendly interface and the potential for services and automations to be reused seemlessly, without the user having to learn the verbatim of our integration.

Thanks @eifinger! Here's a datetime implementation for reference. It is straightforward, we basically need:

• a property named native_value that returns the datetime fetched by the update coordinador (in our case it is stored in self._coordinator.data)

    @property
    def native_value(self) -> datetime | None:
        """Return the latest value."""
        if (data := self._coordinator.data) is None:
            return None

        now = dt.now()
        device_weekday = data["dayofweek"] - 1
        this_weekday = now.weekday()

        if device_weekday != this_weekday:
            days_diff = this_weekday - device_weekday
            if days_diff < 0:
                days_diff += 7
            now -= timedelta(days=days_diff)

        return now.replace(
            hour=data["hour"],
            minute=data["min"],
            second=data["sec"],
        )

• a method named async_set_value() that receives a datetime as parameter and sends it to the device

    async def async_set_value(self, value: datetime) -> None:
        """Change the value."""
        await self._device.async_request(
            self._device.api.set_time,
            hour=value.hour,
            minute=value.minute,
            second=value.second,
            day=value.weekday() + 1,
        )

I don't see any practical scenarios beyond exposing the device date/time and adjusting it manually or through automations, but I would still prefer to use the native Home Assistant component. Leveraging native components offers several benefits, such as a user-friendly interface and the potential for services and automations to be reused seemlessly, without the user having to learn the verbatim of our integration.

Removed the service and implemented the datetime platform instead.