… overridden

According to gradle/gradle#19750 as soon as we set the `--add-opens` here, we lost the constraints on JVM size and metaspace that Gradle normally sets. Oops. This possibly explains build instability (especially on Windows) and having to constrain our number of parallel workers in order to avoid our build containers exhausting memory and dying or getting killed by the container runtime.

… overridden

According to gradle/gradle#19750 as soon as we set the `--add-opens` here, we lost the constraints on JVM size and metaspace that Gradle normally sets. Oops. This possibly explains build instability (especially on Windows) and having to constrain our number of parallel workers in order to avoid our build containers exhausting memory and dying or getting killed by the container runtime.

Due to gradle/gradle#19750 Gradle doesn't set a default
value for MaxMetaspaceSize when org.gradle.jvmargs is set. This sets it explicitly
to what the default value is define in https://github.com/gradle/gradle/blob/6ccf8a2cc74c8060992bd36189dec929143caed7/subprojects/launcher/src/main/java/org/gradle/launcher/daemon/configuration/DaemonParameters.java#L39

## Proposed Changes

Due to gradle/gradle#19750 Gradle doesn't set a default
value for MaxMetaspaceSize when org.gradle.jvmargs is set and the JVM 8 default is
unbounded. This sets it explicitly to the default value defined in https://github.com/gradle/gradle/blob/6ccf8a2cc74c8060992bd36189dec929143caed7/subprojects/launcher/src/main/java/org/gradle/launcher/daemon/configuration/DaemonParameters.java#L39

## Testing

Test: None

## Issues Fixed

Daemon disappearing in CI

This is an imported pull request from #331.

Resolves #331
Github-Pr-Head-Sha: 9af0a74
GitOrigin-RevId: 5ec9a52
Change-Id: I669a8761fddee8fe4b1fb0c6e698256bd907612d

Previously, setting any value for `org.gradle.jvmargs` caused all default settings to be lost.
This often resulted in important defaults like `-XXMaxMetaspaceSize` being omitted when a user
attempted to provide more memory to a build process.

With this change, default jvmargs will be retained unless specifically overridden by a user-supplied argument.
One exception is that setting either -Xmx or -Xms will cause the default heap size settings to be omitted, preventing
user-supplied values from conflicting with default values (like having a min heap larger than max heap).

Fixes #19750

Context: gradle/gradle#19750

Previously, setting any value for `org.gradle.jvmargs` caused all default settings to be lost.
This often resulted in important defaults like `-XXMaxMetaspaceSize` being omitted when a user
attempted to provide more memory to a build process.

With this change, default jvmargs will be retained unless specifically overridden by a user-supplied argument.
One exception is that setting either -Xmx or -Xms will cause the default heap size settings to be omitted, preventing
user-supplied values from conflicting with default values (like having a min heap larger than max heap).

Fixes #19750

Previously, setting any value for `org.gradle.jvmargs` caused all default settings to be lost.
This often resulted in important defaults like `-XXMaxMetaspaceSize` being omitted when a user
attempted to provide more memory to a build process.

With this change, default jvmargs will be retained unless specifically overridden by a user-supplied argument.
One exception is that setting either -Xmx or -Xms will cause the default heap size settings to be omitted, preventing
user-supplied values from conflicting with default values (like having a min heap larger than max heap).

Fixes #19750

Previously, setting any value for `org.gradle.jvmargs` caused all default settings to be lost.
This often resulted in important defaults like `-XXMaxMetaspaceSize` being omitted when a user
attempted to provide more memory to a build process.

With this change, default jvmargs will be retained unless specifically overridden by a user-supplied argument.
One exception is that setting either -Xmx or -Xms will cause the default heap size settings to be omitted, preventing
user-supplied values from conflicting with default values (like having a min heap larger than max heap).

Fixes #19750

Previously, setting any value for `org.gradle.jvmargs` caused all default settings to be lost.
This often resulted in important defaults like `-XXMaxMetaspaceSize` being omitted when a user
attempted to provide more memory to a build process.

With this change, default jvmargs will be retained unless specifically overridden by a user-supplied argument.
One exception is that setting either -Xmx or -Xms will cause the default heap size settings to be omitted, preventing
user-supplied values from conflicting with default values (like having a min heap larger than max heap).

Fixes #19750

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

According to gradle/gradle#19750 setting the org.gradle.jvmargs property can lead to "Daemon disappeared" failures
by removing the default values.
Also use -XX:+UseParallelGC to improve build performance.

…aspaceSize` (#143085)

Re-sets two jvmargs that were getting cleared because we set a value for `-Xmx`. Could help with #142957. Copied from comment here #142957:
>Two random things I ran into while looking into this that might help:
>
>1. Gradle has defaults for a couple of the jvmargs, and setting any one of them clears those defaults for the others (bug here gradle/gradle#19750). This can cause the "Gradle daemon to consume more and more native memory until it crashes", though the bug typically has a different associated error. It seems worth it to re-set those defaults.
>2. There is a property we can set that will give us a heap dump on OOM ([-XX:HeapDumpOnOutOfMemoryError](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/clopts001.html))

Mostly just a find and replace from `find . -name gradle.properties -exec sed -i '' 's/\-Xmx4G/-Xmx4G\ \-XX:MaxMetaspaceSize=2G\ \-XX:+HeapDumpOnOutOfMemoryError/g' {} \;`, with the templates and the one test that writes from a string replaced by hand. I didn't set a value for `MaxMetaspaceSize` in the template files because I want to make sure this value doesn't cause problems in ci first (changes to the templates are essentially un-revertable for those who `flutter create` while the changes exist).

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

Signed-off-by: Justin Florentine <[email protected]>

See gradle/gradle#19750 and
https://developer.android.com/build/optimize-your-build#experiment-with-the-jvm-parallel-garbage-collector
for more info.
This should enable the parallel GC on Java 9+, as well as
other defaults that Gradle would set otherwise.

- Add `-XX:MaxMetaspaceSize` (gradle/gradle#19750)
- Remove `-PpreDexEnable` as it's deprecated and no longer used.
- Remove `--max-workers` as gradle will automatically use the optimal amount.

* Try to workaround OOM errors and the runner dying

* Some more tweaks:

- Add `-XX:MaxMetaspaceSize` (gradle/gradle#19750)
- Remove `-PpreDexEnable` as it's deprecated and no longer used.
- Remove `--max-workers` as gradle will automatically use the optimal amount.

* Remove `--max-workers` in recording screenshots too