Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use autogenerated methods to get names from admin samples #1110

Merged
merged 3 commits into from
Mar 4, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
use database_admin_api for instance_path
  • Loading branch information
rahul2393 committed Mar 4, 2024
commit 9ee3911a0e5b15202b3742707f4625dce3a720ed
13 changes: 5 additions & 8 deletions samples/samples/backup_sample.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,13 @@ def create_backup(instance_id, database_id, backup_id, version_time):
backup as backup_pb

spanner_client = spanner.Client()
instance_admin_api = spanner_client.instance_admin_api
database_admin_api = spanner_client.database_admin_api

# Create a backup
expire_time = datetime.utcnow() + timedelta(days=14)

request = backup_pb.CreateBackupRequest(
parent=instance_admin_api.instance_path(spanner_client.project, instance_id),
parent=database_admin_api.instance_path(spanner_client.project, instance_id),
backup_id=backup_id,
backup=backup_pb.Backup(
database=database_admin_api.database_path(
Expand Down Expand Up @@ -83,7 +82,6 @@ def create_backup_with_encryption_key(
backup as backup_pb

spanner_client = spanner.Client()
instance_admin_api = spanner_client.instance_admin_api
database_admin_api = spanner_client.database_admin_api

# Create a backup
Expand All @@ -93,7 +91,7 @@ def create_backup_with_encryption_key(
"kms_key_name": kms_key_name,
}
request = backup_pb.CreateBackupRequest(
parent=instance_admin_api.instance_path(spanner_client.project, instance_id),
parent=database_admin_api.instance_path(spanner_client.project, instance_id),
backup_id=backup_id,
backup=backup_pb.Backup(
database=database_admin_api.database_path(
Expand Down Expand Up @@ -211,14 +209,13 @@ def cancel_backup(instance_id, database_id, backup_id):
backup as backup_pb

spanner_client = spanner.Client()
instance_admin_api = spanner_client.instance_admin_api
database_admin_api = spanner_client.database_admin_api

expire_time = datetime.utcnow() + timedelta(days=30)

# Create a backup.
request = backup_pb.CreateBackupRequest(
parent=instance_admin_api.instance_path(spanner_client.project, instance_id),
parent=database_admin_api.instance_path(spanner_client.project, instance_id),
backup_id=backup_id,
backup=backup_pb.Backup(
database=database_admin_api.database_path(
Expand All @@ -241,7 +238,7 @@ def cancel_backup(instance_id, database_id, backup_id):
database_admin_api.get_backup(
backup_pb.GetBackupRequest(
name="{}/backups/{}".format(
instance_admin_api.instance_path(
database_admin_api.instance_path(
spanner_client.project, instance_id
),
backup_id,
Expand All @@ -255,7 +252,7 @@ def cancel_backup(instance_id, database_id, backup_id):
database_admin_api.delete_backup(
backup_pb.DeleteBackupRequest(
name="{}/backups/{}".format(
instance_admin_api.instance_path(spanner_client.project, instance_id),
database_admin_api.instance_path(spanner_client.project, instance_id),
backup_id,
)
)
Expand Down