Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a new directory for archived samples of admin APIs. #1102

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

rahul2393
Copy link
Contributor

This is a pre-cursor step as the directory hyperlink is needed to form other documentation (release notes).

  • All archived samples will be moved to the directory samples/samples/archived

@rahul2393 rahul2393 requested review from a team as code owners February 14, 2024 05:21
@product-auto-label product-auto-label bot added size: u Pull request is empty. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Feb 14, 2024
@rahul2393 rahul2393 requested review from arpan14 and removed request for arpan14 February 14, 2024 09:14
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the samples are considered archived, can we omit them from this repo?

@rahul2393
Copy link
Contributor Author

rahul2393 commented Feb 14, 2024

If the samples are considered archived, can we omit them from this repo?

We will be redirecting the users to old samples in our documentation pages, and will not remove the existing public samples from this repository

Similar approach is what we are following in other libraries
googleapis/java-spanner#2886
googleapis/nodejs-spanner#1997

@rahul2393 rahul2393 merged commit b0a31e9 into main Feb 14, 2024
14 of 16 checks passed
@rahul2393 rahul2393 deleted the admin-sample-archive-dir branch February 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: u Pull request is empty.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants