Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: samples and tests for admin database APIs #1099

Merged
merged 13 commits into from
Feb 26, 2024
Merged

docs: samples and tests for admin database APIs #1099

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4ec3c25
docs: samples and tests for admin database APIs
rahul2393 Feb 9, 2024
99367f2
rebase branch with main
rahul2393 Feb 19, 2024
dc05bfe
remove backup samples
rahul2393 Feb 20, 2024
b5ba082
add more database samples
rahul2393 Feb 20, 2024
61ea41f
remove unused import
rahul2393 Feb 20, 2024
b18c55e
add more samples
rahul2393 Feb 21, 2024
c7a5882
Merge branch 'main' into database_admin_samples
harshachinta Feb 21, 2024
4f6ecce
incorporate suggestions
rahul2393 Feb 22, 2024
2d8a528
fix tests
rahul2393 Feb 22, 2024
f18d0e1
incorporate suggestions
rahul2393 Feb 23, 2024
48e13e8
fix tests
rahul2393 Feb 23, 2024
ed20cd5
remove parallel run
rahul2393 Feb 23, 2024
eff4e82
Merge branch 'main' into database_admin_samples
rahul2393 Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
remove parallel run
  • Loading branch information
@rahul2393
rahul2393 committed Feb 23, 2024
commit ed20cd5520bd802cf931b520e0756539d5f8f553
6 changes: 2 additions & 4 deletions samples/samples/admin/samples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,12 +235,10 @@ def update_database_with_default_leader(instance_id, database_id, default_leader
)
operation = spanner_client.database_admin_api.update_database_ddl(request)

db = operation.result(OPERATION_TIMEOUT_SECONDS)
operation.result(OPERATION_TIMEOUT_SECONDS)

print(
"Database {} updated with default leader {}".format(
db.name, db.default_leader
)
"Database {} updated with default leader {}".format(database_id, default_leader)
)


Expand Down
1 change: 0 additions & 1 deletion samples/samples/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
google-cloud-spanner==3.42.0
futures==3.4.0; python_version < "3"
pytest-xdist==3.3.1 # Pinned to unbreak unit tests