feat: Managed Autoscalar feature #1038
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
harshachinta
commented
Nov 27, 2023
surbhigarg92
reviewed
Feb 8, 2024
| "autoscaling_config", | ||
| ] | ||
| if self._autoscaling_config is not None: | ||
| # When switching from non-autoscalar to autoscalar instance, |
There was a problem hiding this comment.
nit: set paths in a if else condition
| @@ -291,6 +298,49 @@ def test_create_with_processing_units(self): | |||
| self.assertEqual(instance.labels, self.LABELS) | |||
| self.assertEqual(metadata, [("google-cloud-resource-prefix", instance.name)]) | |||
|
|
|||
| def test_create_with_autoscaling_config(self): | |||
There was a problem hiding this comment.
Update any existing test eg: test_create_with_processing_units and add autoscaling_config with a comment that autoscaling_config should always be set irrespective of processing_unit or node_count
surbhigarg92
approved these changes
Feb 22, 2024
|
Closing this because of #1111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[DO NOT MERGE]
This PR adds code changes for Managed Autoscalar feature.
Add the ability to create / update an instance with autoscaling config. Note that now user can only specify one of the node_count, processing_units or autoscaling_config as the compute capacity for an instance.
Add the ability to see autoscaling config with an instance