Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Untyped param #1001

Merged
merged 13 commits into from
Feb 13, 2024
Merged

feat: Untyped param #1001

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e5a1830
changes
asthamohta Jul 19, 2023
5a703b5
Merge branch 'main' into untyped_param
asthamohta Aug 10, 2023
bd346da
change
asthamohta Aug 16, 2023
82aa5ca
tests
asthamohta Aug 17, 2023
e01d9b4
tests
asthamohta Aug 17, 2023
9f8a92d
changes
asthamohta Aug 17, 2023
d9040e9
change
asthamohta Aug 17, 2023
6a689fa
lint
asthamohta Aug 17, 2023
4a86eca
Merge branch 'main' into untyped_param
asthamohta Aug 17, 2023
d2b84da
lint
asthamohta Aug 17, 2023
5415b28
Merge branch 'untyped_param' of github.com:asthamohta/python-spanner …
asthamohta Aug 17, 2023
e229b7e
Merge branch 'main' into untyped_param
asthamohta Feb 5, 2024
2cb87cf
Merge branch 'main' into untyped_param
surbhigarg92 Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
changes
  • Loading branch information
@asthamohta
asthamohta committed Jul 19, 2023
commit e5a1830c021cce612e02e8495a12068fb59fcef3
2 changes: 1 addition & 1 deletion google/cloud/spanner_v1/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,7 +629,7 @@ def execute_partitioned_dml(
from google.cloud.spanner_v1.transaction import Transaction

if param_types is None:
raise ValueError("Specify 'param_types' when passing 'params'.")
param_types = {}
params_pb = Transaction._make_params_pb(params, param_types)
else:
params_pb = {}
Expand Down
4 changes: 2 additions & 2 deletions google/cloud/spanner_v1/snapshot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def execute_sql(

if params is not None:
if param_types is None:
raise ValueError("Specify 'param_types' when passing 'params'.")
param_types = {}
params_pb = Struct(
fields={key: _make_value_pb(value) for key, value in params.items()}
)
Expand Down Expand Up @@ -633,7 +633,7 @@ def partition_query(

if params is not None:
if param_types is None:
raise ValueError("Specify 'param_types' when passing 'params'.")
param_types = {}
params_pb = Struct(
fields={key: _make_value_pb(value) for (key, value) in params.items()}
)
Expand Down
5 changes: 0 additions & 5 deletions google/cloud/spanner_v1/transaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,14 +267,9 @@ def _make_params_pb(params, param_types):
If ``params`` is None but ``param_types`` is not None.
"""
if params is not None:
if param_types is None:
raise ValueError("Specify 'param_types' when passing 'params'.")
return Struct(
fields={key: _make_value_pb(value) for key, value in params.items()}
)
else:
if param_types is not None:
raise ValueError("Specify 'params' when passing 'param_types'.")

return {}

Expand Down
32 changes: 31 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,37 @@
namespaces = ["google"]
if "google.cloud" in packages:
namespaces.append("google.cloud")

print(
[name,
version,
description,
readme,
"Google LLC",
"[email protected]",
"Apache 2.0",
url,
[
release_status,
"Intended Audience :: Developers",
"License :: OSI Approved :: Apache Software License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Operating System :: OS Independent",
"Topic :: Internet",
],
"Posix; MacOS X; Windows",
packages,
namespaces,
dependencies,
extras,
">=3.7",
True,
False]
)
setuptools.setup(
name=name,
version=version,
Expand Down