feat: Pass through small IN queries to the server. #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e21c1e
to
f2c3a87
Compare
f2c3a87
to
886c8e8
Compare
rwhogg
reviewed
Feb 26, 2024
| @@ -655,7 +658,8 @@ def __new__(cls, name, opsymbol, value): | |||
| return FalseNode() | |||
| if len(nodes) == 1: | |||
| return nodes[0] | |||
| return DisjunctionNode(*nodes) | |||
| if len(nodes) > _SERVER_IN_LIMIT: | |||
There was a problem hiding this comment.
Can we document this server limit in the docstring?
rwhogg
reviewed
Feb 26, 2024
| never occur since the constructor will create ``OR`` nodes for | ||
| ``!=`` and ``in`` | ||
| ``!=``. |
There was a problem hiding this comment.
It seems like we will still create OR nodes if the list of IN values is >= 31? Or am I misunderstanding?
There was a problem hiding this comment.
Please take a look at #954 instead. I think this is a better short term improvement.
rwhogg
reviewed
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Pass through small IN queries to the server.