New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on six
#913
Labels
api: datastore
Issues related to the googleapis/python-ndb API.
good first issue
This issue is a good place to started contributing to this repository.
Comments
product-auto-label
bot
added
the
api: datastore
Issues related to the googleapis/python-ndb API.
label
Sep 14, 2023
rwhogg
added
good first issue
This issue is a good place to started contributing to this repository.
api: datastore
Issues related to the googleapis/python-ndb API.
and removed
api: datastore
Issues related to the googleapis/python-ndb API.
labels
Sep 14, 2023
snarfed
added a commit
to snarfed/arroba
that referenced
this issue
Sep 15, 2023
sorced-jim
added a commit
to sorced-jim/python-ndb
that referenced
this issue
Mar 1, 2024
sorced-jim
added a commit
that referenced
this issue
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the googleapis/python-ndb API.
good first issue
This issue is a good place to started contributing to this repository.
Describe the solution you'd like
We added a dependency on
six
in #912 because without it, importing the module fails. But it's only needed from the days when we supported Python 2.7 (which we no longer do) and so we'd rather get rid of it.This will require both:
a) removing it from setup.py and the testing constraints files
b) Rewriting all code that imports
six
The latter can likely be accomplished in many cases by inlining the definitions and removing anything that only works/is needed on Python 2
Additional context
See also #911 where it was first noticed that we had an undeclared dependency
The text was updated successfully, but these errors were encountered: