fix: Raise not implemented error when REST transport is not supported (…

…#170) * fix: Raise not implemented error when REST transport is not supported PiperOrigin-RevId: 507594646 Source-Link: googleapis/googleapis@ee8c334 Source-Link: googleapis/googleapis-gen@ac8cbed Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWM4Y2JlZGY0M2IzZTI2ZTk4YjcxM2U0ZDYxOWI1N2VhMWZjNzM3NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Feb 7, 2023 · 44651ca · 44651ca
1 parent ba8af34
commit 44651ca
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py b/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py
@@ -437,8 +437,8 @@ def __call__(
  timeout: Optional[float] = None,
  metadata: Sequence[Tuple[str, str]] = (),
  ) -> jobs.CheckActiveJobsResponse:
- raise RuntimeError(
- "Cannot define a method without a valid 'google.api.http' annotation."
+ raise NotImplementedError(
+ "Method CheckActiveJobs is not available over REST transport"
  )
 
  class _CreateJob(JobsV1Beta3RestStub):

diff --git a/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py b/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py
@@ -4118,11 +4118,10 @@ def test_check_active_jobs_rest_error():
  )
  # Since a `google.api.http` annotation is required for using a rest transport
  # method, this should error.
- with pytest.raises(RuntimeError) as runtime_error:
+ with pytest.raises(NotImplementedError) as not_implemented_error:
  client.check_active_jobs({})
- assert (
- "Cannot define a method without a valid 'google.api.http' annotation."
- in str(runtime_error.value)
+ assert "Method CheckActiveJobs is not available over REST transport" in str(
+ not_implemented_error.value
  )