Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unnecessary API call in QueryJob.result() when job is already finished #1900

Merged
merged 14 commits into from
Apr 18, 2024
+547 −230
Merged

fix: avoid unnecessary API call in QueryJob.result() when job is already finished #1900

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0c9a8a2
fix: avoid unnecessary API call in QueryJob.result() when job is alre…
tswast Apr 12, 2024
07839b5
fix most unit tests
tswast Apr 12, 2024
5112315
fix remaining unit tests
tswast Apr 13, 2024
6297efd
Merge remote-tracking branch 'origin/main' into tswast-fix-query-retry
tswast Apr 13, 2024
e5990eb
add timeout test, remove unneeded _done_or_raise override
tswast Apr 13, 2024
fddb557
treat even finished jobs as PENDING in query_and_wait since we want t…
tswast Apr 13, 2024
6a43cfd
remove unnecessary if statement
tswast Apr 13, 2024
12fa9fb
fix: retry query job after ambiguous failures
tswast Apr 16, 2024
5149c25
Apply suggestions from code review
tswast Apr 17, 2024
4ee4975
add comments explaining expected sequences of API calls
tswast Apr 17, 2024
08373bc
explain timeout choice
tswast Apr 17, 2024
2a587aa
Apply suggestions from code review
tswast Apr 17, 2024
f7f1e81
Merge remote-tracking branch 'origin/tswast-fix-query-retry' into tsw…
tswast Apr 17, 2024
e42d8ad
Update google/cloud/bigquery/job/query.py
chalmerlowe Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Chalmer Lowe <[email protected]>
  • Loading branch information
@tswast @chalmerlowe
tswast and chalmerlowe committed Apr 17, 2024
commit 2a587aa67cb830ef6a173204bb461d2896e9848b
2 changes: 1 addition & 1 deletion tests/unit/test_job_retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def make_job_id(*args, **kwargs):
# jobs.getQueryResults x2
#
# Note: internalError is ambiguous in jobs.getQueryResults. The
# problem could be at the Google Frontend leve or it could be because
# problem could be at the Google Frontend level or it could be because
# the job has failed due to some transient issues and the BigQuery
# REST API is translating the job failed status into failure HTTP
# codes.
Expand Down