Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update error logging when converting to pyarrow column fails #1836

Merged
merged 31 commits into from
Mar 19, 2024
Merged

fix: update error logging when converting to pyarrow column fails #1836

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
0b41532
fix: update error logging when converting to pyarrow column fails
chalmerlowe Feb 29, 2024
f7f0501
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 29, 2024
0d543e4
resolve merge conflict
chalmerlowe Feb 29, 2024
fe5082b
resolve missing dependency
chalmerlowe Feb 29, 2024
e396b01
more tweaks to constraints and requirements re pyarrow
chalmerlowe Feb 29, 2024
0d25ca4
even more tweaks to constraints and requirements re pyarrow
chalmerlowe Feb 29, 2024
71b108f
a few more tweaks to constraints and requirements re pyarrow
chalmerlowe Feb 29, 2024
ead177d
Merge branch 'main' into name-series-in-error-log
chalmerlowe Mar 8, 2024
3220881
Merge branch 'main' into name-series-in-error-log
chalmerlowe Mar 11, 2024
1030756
Merge branch 'main' into name-series-in-error-log
chalmerlowe Mar 12, 2024
55a97ac
resolves issue of pyarrow not installing
chalmerlowe Mar 13, 2024
aeb0739
fix linting issue
chalmerlowe Mar 13, 2024
c262d8c
update linting and conditionals
chalmerlowe Mar 13, 2024
91913b0
update linting and mypy comments
chalmerlowe Mar 13, 2024
e39fe1d
quick tags on several coverage issues related to imports
chalmerlowe Mar 13, 2024
6975ce3
adds pragma to exception
chalmerlowe Mar 14, 2024
17d63be
updates test suite with new test and makes msg explicit
chalmerlowe Mar 15, 2024
f921c07
temporarily adding timing code
chalmerlowe Mar 15, 2024
2186d24
additional timing test mods
chalmerlowe Mar 15, 2024
6cefc01
add pragmas to account for several tests
chalmerlowe Mar 18, 2024
747beb6
Merge branch 'main' into name-series-in-error-log
chalmerlowe Mar 18, 2024
2a49bd5
cleaned up some test code
chalmerlowe Mar 18, 2024
caa0256
cleaned up some test code
chalmerlowe Mar 18, 2024
761b64d
Update a test to include column datatype
chalmerlowe Mar 18, 2024
4be910c
update to pytest.raises command
chalmerlowe Mar 18, 2024
43de81d
Update tests/unit/test__pandas_helpers.py
chalmerlowe Mar 19, 2024
bad4c0c
Merge branch 'main' into name-series-in-error-log
chalmerlowe Mar 19, 2024
0f71762
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 19, 2024
0b786ba
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 19, 2024
73066a4
Merge branch 'name-series-in-error-log' of https://github.com/googlea…
gcf-owl-bot[bot] Mar 19, 2024
2cca046
removed unused variable 'e'
chalmerlowe Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
quick tags on several coverage issues related to imports
  • Loading branch information
@chalmerlowe
chalmerlowe committed Mar 13, 2024
commit e39fe1d44717d4eb70fce07f9f32769af6bfeae0
2 changes: 1 addition & 1 deletion google/cloud/bigquery/_pandas_helpers.py
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@
from pyarrow import ArrowTypeError # type: ignore # noqa: E402

_BIGNUMERIC_SUPPORT = False
if pyarrow is not None:
if pyarrow is not None: # pragma: NO COVER
_BIGNUMERIC_SUPPORT = True

try:
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/bigquery/_pyarrow_helpers.py
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ def pyarrow_timestamp():
_BQ_TO_ARROW_SCALARS = {}
_ARROW_SCALAR_IDS_TO_BQ = {}

if pyarrow:
if pyarrow: # pragma: NO COVER
chalmerlowe marked this conversation as resolved.
Show resolved Hide resolved
# This dictionary is duplicated in bigquery_storage/test/unite/test_reader.py
# When modifying it be sure to update it there as well.
# Note(todo!!): type "BIGNUMERIC"'s matching pyarrow type is added in _pandas_helpers.py
Expand Down