Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support RANGE query parameters #1827

Merged
merged 14 commits into from
Mar 4, 2024
Merged

feat: support RANGE query parameters #1827

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
51cd069
feat: RANGE query parameters and unit tests
Linchin Feb 23, 2024
adf7150
unit test
Linchin Feb 23, 2024
094e47c
unit test coverage
Linchin Feb 24, 2024
ac0e042
lint
Linchin Feb 24, 2024
cb6ed75
lint
Linchin Feb 24, 2024
c154622
lint
Linchin Feb 24, 2024
36529b5
system test
Linchin Feb 24, 2024
5f8d7a8
fix system test
Linchin Feb 24, 2024
9beb7ec
ajust init items order
Linchin Feb 26, 2024
5a4c783
Merge branch 'main' into range-query-params
Linchin Feb 27, 2024
1d20a5e
Merge branch 'main' into range-query-params
Linchin Feb 27, 2024
f7994be
Merge branch 'main' into range-query-params
Linchin Feb 29, 2024
7b6fc41
fix typos and improve docstrings
Linchin Feb 29, 2024
9c3907b
Merge branch 'main' into range-query-params
Linchin Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
system test
  • Loading branch information
@Linchin
Linchin committed Feb 24, 2024
commit 36529b5e4ed58f28b1711999b8b795f27bf829ec
27 changes: 24 additions & 3 deletions tests/system/test_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,16 +425,37 @@ def test_query_statistics(bigquery_client, query_api_method):
],
),
(
"SELECT @date_range",
datetime.date(2016, 12, 5),
"SELECT @range_date",
"[2016-12-05, UNBOUNDED)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 'UNBOUNDED' some kind of type alias, or does the service return that as the literal string? If so, should we convert UNBOUNDED -> None when build query parameter values?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service returns 'UNBOUNDED' as part of the literal string. 'UNBOUNDED' isn't an alias of any type, so it's safe to convert it into None.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Its fine to punt on this aspect, I just wanted to clarify.

[
RangeQueryParameter(
name="date_range",
name="range_date",
range_element_type="DATE",
start=datetime.date(2016, 12, 5),
)
],
),
(
"SELECT @range_datetime",
"[2016-12-05T12:00:00.000000, UNBOUNDED)",
[
RangeQueryParameter(
name="range_datetime",
range_element_type="DATETIME",
start=datetime.datetime(2016, 12, 5),
)
],
),
(
"SELECT @range_unbounded",
"[UNBOUNDED, UNBOUNDED)",
[
RangeQueryParameter(
name="range_unbounded",
range_element_type="DATETIME",
)
],
),
),
)
def test_query_parameters(
Expand Down