Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw exception for data type mismatch for load_table_from_dataf… #1824

Closed
wants to merge 1 commit into from

Conversation

Gaurang033
Copy link
Contributor

Fixes #1822

@Gaurang033 Gaurang033 requested review from a team as code owners February 21, 2024 18:18
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 21, 2024
@chalmerlowe
Copy link
Contributor

Thanks for jumping on this so quickly.
I suspect that since we are adding a new flow path through the code, we will encounter a coverage issue because that path is not tested.

We will likely need at least one new test to test this path.

@chalmerlowe chalmerlowe self-assigned this Feb 21, 2024
@Gaurang033
Copy link
Contributor Author

Thanks for jumping on this so quickly. I suspect that since we are adding a new flow path through the code, we will encounter a coverage issue because that path is not tested.

We will likely need at least one new test to test this path.

I can add a unit test for this if you like

@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 26, 2024
@Gaurang033 Gaurang033 force-pushed the feature/fix_1822 branch 2 times, most recently from ba2ac46 to 06c357d Compare March 13, 2024 12:57
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 13, 2024
@Gaurang033
Copy link
Contributor Author

Unit test was failing as exception thrown in python 3.7 and 3.8 and higher version was different. changed the assertion to use regex and tested locally with both the version. Tests should pass now.

@chalmerlowe
Copy link
Contributor

@Gaurang033
I had multiple issues and PRs come together at the same time including this PR.

I took various parts of each of them and have merged them into a single PR.
This PR will be closed as soon as the tests and review are complete on PR #1836

So please don't devote any additional time to this PR.
If you have comments, thoughts, ideas or suggestions for #1836, feel free to add them there. Thanks so much for getting this ball rolling and offering your time and help. It is much appreciated.

@chalmerlowe
Copy link
Contributor

Closed by the merger of #1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raised ArrowTypeError should indicates which column is causing the error
5 participants