Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use mock from unittest #1823

Merged
merged 12 commits into from
Mar 7, 2024
Merged

chore: use mock from unittest #1823

merged 12 commits into from
Mar 7, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Feb 21, 2024

Replace mock with unittest.mock to reduce the number of test dependencies

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 21, 2024
@chalmerlowe chalmerlowe marked this pull request as ready for review March 7, 2024 18:09
@chalmerlowe chalmerlowe requested review from a team as code owners March 7, 2024 18:09
@chalmerlowe chalmerlowe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2024
kiraksi
kiraksi reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kiraksi kiraksi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one comment

noxfile.py Show resolved Hide resolved
kiraksi
kiraksi approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@kiraksi kiraksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalmerlowe chalmerlowe merged commit 08762fb into main Mar 7, 2024
21 checks passed
@chalmerlowe chalmerlowe deleted the use-mock-from-unittest branch March 7, 2024 20:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe left review comments

@kiraksi kiraksi kiraksi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parthea @chalmerlowe @kiraksi