Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spanner): add emulator support for the admin client autogenerated API samples #1994

Merged
merged 57 commits into from
Feb 28, 2024
Merged
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d992e90
feat(spanner): emulator support for admin client apis samples
alkatrivedi Feb 13, 2024
0cda32c
fix: lint errors
alkatrivedi Feb 13, 2024
1da0d06
docs: add comment
alkatrivedi Feb 13, 2024
8a8fcfb
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 13, 2024
1836197
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 14, 2024
c0ba211
refactor: remove redundant code lines
alkatrivedi Feb 14, 2024
ae8c194
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 14, 2024
6084578
refactor: renamed the helper function for the admin client API calls
alkatrivedi Feb 14, 2024
d00e7bd
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 14, 2024
e9e72e1
refactor: remove redundant code lines
alkatrivedi Feb 14, 2024
bb79fed
refactor if condition
alkatrivedi Feb 14, 2024
88aa219
refactor comments
alkatrivedi Feb 19, 2024
b414ef1
refactor: remove added logs
alkatrivedi Feb 19, 2024
6791652
chore: update helper functions for admin clients
alkatrivedi Feb 21, 2024
070c735
refactor: remove unneeded imports
alkatrivedi Feb 21, 2024
51e3fda
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 22, 2024
cdfff7f
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 23, 2024
5e98c3f
Merge branch 'googleapis:main' into admin-emulator-support
alkatrivedi Feb 23, 2024
f3ba05a
refactor: documention of get instance/database admin client method
alkatrivedi Feb 23, 2024
70ea49f
test: add the integration test for emulator support
alkatrivedi Feb 26, 2024
bec0fce
fix: header-checks
alkatrivedi Feb 26, 2024
7b36a00
fix: error in integration test
alkatrivedi Feb 26, 2024
9160ae0
fix: lint errors
alkatrivedi Feb 26, 2024
b2d578d
fix: header-checks
alkatrivedi Feb 26, 2024
d070abb
fix: license error
alkatrivedi Feb 26, 2024
d265645
fix: header-checks
alkatrivedi Feb 26, 2024
09847ce
fix: presubmit error
alkatrivedi Feb 26, 2024
2b25618
fix: presubmit error
alkatrivedi Feb 26, 2024
3754fae
fix: presubmit error
alkatrivedi Feb 26, 2024
1d5cb85
fix: presubmit errors
alkatrivedi Feb 26, 2024
336f1c9
fix: lint error
alkatrivedi Feb 26, 2024
ceb3a9c
Documentation and method names
surbhigarg92 Feb 27, 2024
4550b07
refactor integration test
alkatrivedi Feb 27, 2024
fbba14a
fix presubmit error
alkatrivedi Feb 27, 2024
1c6104f
fix: lint error
alkatrivedi Feb 27, 2024
5d7cdd6
fix: methods documentation
alkatrivedi Feb 27, 2024
b05ec94
refactor: methods name
alkatrivedi Feb 27, 2024
e756390
fix: presubmit error
alkatrivedi Feb 27, 2024
1e6cf67
Documentation changes
surbhigarg92 Feb 27, 2024
bf1590c
Refactor system tests
surbhigarg92 Feb 27, 2024
f122cbc
refactor: integration tests
alkatrivedi Feb 27, 2024
c0f4b3a
refactor code
alkatrivedi Feb 27, 2024
f5a536f
fix: lint error
alkatrivedi Feb 27, 2024
336c78e
refactor: remove redundant file
alkatrivedi Feb 27, 2024
fe119e3
fix: presubmit error
alkatrivedi Feb 27, 2024
65c8967
fix: presubmit error
alkatrivedi Feb 27, 2024
e52d926
test: add configrations for testing in local
alkatrivedi Feb 27, 2024
828d6cc
refactor: integration test
alkatrivedi Feb 27, 2024
6b95faa
fix: presubmit error
alkatrivedi Feb 27, 2024
53d7dec
review comments
surbhigarg92 Feb 27, 2024
ac04630
review comments
surbhigarg92 Feb 27, 2024
db0c65d
Apply suggestions from code review
surbhigarg92 Feb 27, 2024
9289cda
review comments
surbhigarg92 Feb 27, 2024
4603ebe
review comments
surbhigarg92 Feb 27, 2024
cfa7196
review comments
surbhigarg92 Feb 27, 2024
cb004f2
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 27, 2024
aedbb14
review comments
surbhigarg92 Feb 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor comments
  • Loading branch information
alkatrivedi committed Feb 19, 2024
commit 88aa2195f4308fd554c59d6a73674bdccd275ec4
7 changes: 5 additions & 2 deletions src/index.ts
Expand Up @@ -353,7 +353,7 @@
this.emulatorHost = emulatorHost;
}

// Helper for session-related instance admin client API calls
// Helper for instance admin client API calls
alkatrivedi marked this conversation as resolved.
Show resolved Hide resolved
create_instance_admin_client(this): void {
if (!this._instance_admin_api) {
this._instance_admin_api = new InstanceAdminClient();
Expand All @@ -367,7 +367,7 @@
return this._instance_admin_api;
}

// Helper for session-related database admin client API calls
// Helper for database admin client API calls
create_database_admin_client(this): void {
if (!this._database_admin_api) {
this._database_admin_api = new DatabaseAdminClient();
Expand All @@ -383,9 +383,12 @@

/** Closes this Spanner client and cleans up all resources used by it. */
close(): void {
console.log("inside close method index.ts");

Check failure on line 386 in src/index.ts

View workflow job for this annotation

GitHub Actions / lint

Replace `"inside·close·method·index.ts"` with `'inside·close·method·index.ts'`

Check warning on line 386 in src/index.ts

View workflow job for this annotation

GitHub Actions / lint

Strings must use singlequote
console.log(this.clients_);
this.clients_.forEach(c => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const client = c as any;
console.log("the client is: ", client);

Check failure on line 391 in src/index.ts

View workflow job for this annotation

GitHub Actions / lint

Replace `"the·client·is:·"` with `'the·client·is:·'`

Check warning on line 391 in src/index.ts

View workflow job for this annotation

GitHub Actions / lint

Strings must use singlequote
if (client.operationsClient && client.operationsClient.close) {
client.operationsClient.close();
}
Expand Down