Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Samples and tests for Instance Admin Client APIs #1987

Merged
merged 28 commits into from
Feb 28, 2024
Merged

docs: Samples and tests for Instance Admin Client APIs #1987

merged 28 commits into from
Feb 28, 2024

Conversation

alkatrivedi
Copy link
Contributor

This PR contains sample files and their integration tests for the instance admin client APIs.

@alkatrivedi alkatrivedi requested review from a team as code owners January 20, 2024 18:12
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 20, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 20, 2024 •
edited

Here is the summary of changes.

You are about to add 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 20, 2024
olavloite
olavloite reviewed Jan 22, 2024
View reviewed changes
samples/v2/instance.js Outdated Show resolved Hide resolved
samples/v2/instance.js Outdated Show resolved Hide resolved
samples/v2/instance.js Show resolved Hide resolved
samples/v2/instance-config-create.js Outdated Show resolved Hide resolved
samples/v2/instance-config-create.js Outdated Show resolved Hide resolved
samples/v2/instance-config-get-operations.js Show resolved Hide resolved
samples/v2/instance-config-update.js Outdated Show resolved Hide resolved
samples/v2/instance-config-update.js Show resolved Hide resolved
samples/v2/instance-with-autoscaling-config.js Outdated Show resolved Hide resolved
samples/v2/instance-with-processing-units.js Outdated Show resolved Hide resolved
alkatrivedi and others added 18 commits January 28, 2024 18:12
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
9cc07e2
@alkatrivedi
fix: add comments
1c89cd6
@alkatrivedi
fix: add emulator support for instance admin client
0bce60f
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
a381cdc
@alkatrivedi
fix: emulator support to admin client
91705ff
@alkatrivedi
fix: remove unnecessary comments
417e040
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
c3cd5b6
@alkatrivedi
fix: remove instance admin client emulator support
9c84ea2
@alkatrivedi
fix: lint errors
37123d6
@alkatrivedi
docs: remove redundant code lines
ab5c3ad
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
0cadac2
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
6211e29
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
e58f8a0
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
efc0a5c
@alkatrivedi
refactor code
916fda5
@alkatrivedi
Merge branch 'googleapis:main' into apis-admin-instance
108df03
@alkatrivedi
refactor: autogen samples
20dbae3
@alkatrivedi
refactor: samples integraiton test
3f0b188
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: xl Pull request size is extra large. labels Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
olavloite
olavloite approved these changes Feb 28, 2024
View reviewed changes
samples/v2/get-instance-config.js Outdated Show resolved Hide resolved
samples/v2/instance-config-get-operations.js Outdated Show resolved Hide resolved
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@alkatrivedi alkatrivedi added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@alkatrivedi alkatrivedi added the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 494a996 into googleapis:main Feb 28, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 28, 2024
@alkatrivedi alkatrivedi deleted the apis-admin-instance branch March 5, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@arpan14 arpan14 Awaiting requested review from arpan14

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alkatrivedi @olavloite @yoshi-kokoro