Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Samples and tests for Database Admin Client APIs #1986

Merged
merged 24 commits into from
Feb 29, 2024
Merged

docs: Samples and tests for Database Admin Client APIs #1986

merged 24 commits into from
Feb 29, 2024

Conversation

alkatrivedi
Copy link
Contributor

This PR contains sample files and their integration tests for the database admin client APIs.

@alkatrivedi alkatrivedi requested review from a team as code owners January 20, 2024 10:39
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Jan 20, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Jan 20, 2024 •
edited

Here is the summary of changes.

You are about to add 20 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jan 20, 2024
olavloite
olavloite reviewed Jan 22, 2024
View reviewed changes
samples/v2/database-create-with-default-leader.js Outdated Show resolved Hide resolved
samples/v2/database-create-with-default-leader.js Outdated Show resolved Hide resolved
samples/v2/database-create-with-default-leader.js Outdated Show resolved Hide resolved
samples/v2/database-create-with-encryption-key.js Outdated Show resolved Hide resolved
samples/v2/database-create-with-version-retention-period.js Outdated Show resolved Hide resolved
samples/v2/schema.js Show resolved Hide resolved
samples/v2/table-alter-with-foreign-key-delete-cascade Outdated Show resolved Hide resolved
samples/v2/table-alter-with-foreign-key-delete-cascade Outdated Show resolved Hide resolved
samples/v2/table-drop-foreign-key-constraint-delete-cascade.js Show resolved Hide resolved
system-test/spanner.ts Outdated Show resolved Hide resolved
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@arpan14
Copy link

arpan14 commented Feb 29, 2024

LGTM, please make sure you correct the close() methods invocation before merging.

olavloite
olavloite approved these changes Feb 29, 2024
View reviewed changes
samples/v2/add-and-drop-new-database-role.js Outdated Show resolved Hide resolved
samples/v2/database-update.js Outdated Show resolved Hide resolved
samples/v2/database-update.js Outdated Show resolved Hide resolved
samples/v2/database-update.js Outdated Show resolved Hide resolved
samples/v2/index-create.js Show resolved Hide resolved
samples/v2/table-drop-foreign-key-constraint-delete-cascade.js Show resolved Hide resolved
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 29, 2024
@alkatrivedi alkatrivedi added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@alkatrivedi alkatrivedi added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 29, 2024
@alkatrivedi alkatrivedi added the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit f34a33a into googleapis:main Feb 29, 2024
16 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 29, 2024
@alkatrivedi alkatrivedi deleted the apis-admin-database branch March 5, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@arpan14 arpan14 arpan14 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alkatrivedi @arpan14 @olavloite @yoshi-kokoro