Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PreciseDate constructor when value is timestamp 1970-01-01 00:00:00 UTC #1354

Closed
wants to merge 1 commit into from
Closed

fix: PreciseDate constructor when value is timestamp 1970-01-01 00:00:00 UTC #1354

wants to merge 1 commit into from

Conversation

guisalim
Copy link

@guisalim guisalim commented Apr 8, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1353 馃

@guisalim guisalim requested review from a team as code owners April 8, 2024 17:37
@guisalim guisalim requested a review from shollyman April 8, 2024 17:37
@google-cla Google CLA
Copy link

google-cla bot commented Apr 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 8, 2024
@guisalim
Copy link
Author

guisalim commented Apr 8, 2024

CLA already signed

@alvarowolfx alvarowolfx self-requested a review April 8, 2024 18:22
@guisalim guisalim mentioned this pull request Apr 8, 2024
Closed
@alvarowolfx alvarowolfx mentioned this pull request Apr 8, 2024
Merged
@alvarowolfx
Copy link
Contributor

superseeded by #1355

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner automatically assigned from googleapis/api-bigquery

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library cannot parse timestamp value "0" - Cannot convert a BigInt value to a number as PreciseDate
2 participants
@guisalim @alvarowolfx