Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate jobs.query and stateless query for faster queries #1337

Merged
merged 13 commits into from
Mar 27, 2024
+605 −99
Merged

feat: integrate jobs.query and stateless query for faster queries #1337

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c2a6841
feat: integrate jobs.query and jobless query for faster queries
alvarowolfx Feb 16, 2024
344c2ce
feat: rename probeFastPath method to convert queryRequests
alvarowolfx Feb 22, 2024
ed4381c
fix: avoid promisify of buildQueryRequest method
alvarowolfx Feb 28, 2024
af93d2b
Merge branch 'main' into feat-fast-query-path
alvarowolfx Feb 28, 2024
1a3be39
feat: re-generate types
alvarowolfx Feb 28, 2024
0717724
feat: support stateless queries
alvarowolfx Feb 28, 2024
970e08f
feat: fully build QueryRequest object for jobs.query
alvarowolfx Mar 11, 2024
bce8c48
fix: lint issues
alvarowolfx Mar 12, 2024
3757849
Merge branch 'main' into feat-fast-query-path
alvarowolfx Mar 18, 2024
9a2cce5
feat: only use jobCreationMode with preview feature enable
alvarowolfx Mar 19, 2024
7531a12
fix: address code review comments
alvarowolfx Mar 26, 2024
7141834
Merge branch 'main' into feat-fast-query-path
alvarowolfx Mar 27, 2024
f6b19df
Merge branch 'main' into feat-fast-query-path
alvarowolfx Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: lint issues
  • Loading branch information
@alvarowolfx
alvarowolfx committed Mar 12, 2024
commit bce8c4866b66b38c257843eef595f1f90184ea71
57 changes: 28 additions & 29 deletions test/bigquery.ts
View file
Open in desktop
Expand Up @@ -2143,14 +2143,15 @@ describe('BigQuery', () => {
it('should allow for optional parameter types', () => {
const queryParameter = {};

sandbox.replace(BigQuery, 'valueToQueryParameter_', (
value: {},
providedType: string
) => {
assert.strictEqual(value, NAMED_PARAMS.key);
assert.strictEqual(providedType, NAMED_TYPES.key);
return queryParameter;
});
sandbox.replace(
BigQuery,
'valueToQueryParameter_',
(value: {}, providedType: string) => {
assert.strictEqual(value, NAMED_PARAMS.key);
assert.strictEqual(providedType, NAMED_TYPES.key);
return queryParameter;
}
);
bq.createJob = (reqOpts: JobOptions) => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
assert.strictEqual((reqOpts as any).params, undefined);
Expand Down Expand Up @@ -2898,27 +2899,25 @@ describe('BigQuery', () => {
callback(null, fakeJob, {
jobComplete: true,
schema: {
fields: [
{name: 'value', type: 'INT64'}
]
fields: [{name: 'value', type: 'INT64'}],
},
rows: [
{f: [{v: 1}]},
{f: [{v: 2}]},
{f: [{v: 3}]},
],
rows: [{f: [{v: 1}]}, {f: [{v: 2}]}, {f: [{v: 3}]}],
});
};

bq.query(QUERY_STRING, (err: Error, rows: {}, resp: {}) => {
assert.ifError(err);
assert.deepStrictEqual(rows, [{
value: 1,
},{
value: 2
},{
value: 3
}]);
assert.deepStrictEqual(rows, [
{
value: 1,
},
{
value: 2,
},
{
value: 3,
},
]);
assert.strictEqual(resp, FAKE_RESPONSE);
done();
});
Expand Down Expand Up @@ -3023,7 +3022,7 @@ describe('BigQuery', () => {
},
};
const req = bq.buildQueryRequest_(q, {});
for (let key in req) {
for (const key in req) {
if (req[key] === undefined) {
delete req[key];
}
Expand Down Expand Up @@ -3063,7 +3062,7 @@ describe('BigQuery', () => {

it('should create a QueryRequest from a SQL string', () => {
const req = bq.buildQueryRequest_(QUERY_STRING, {});
for (let key in req) {
for (const key in req) {
if (req[key] === undefined) {
delete req[key];
}
Expand Down Expand Up @@ -3116,7 +3115,7 @@ describe('BigQuery', () => {
},
{
query: QUERY_STRING,
jobId: 'fixed-job-id'
jobId: 'fixed-job-id',
},
{
query: QUERY_STRING,
Expand All @@ -3125,11 +3124,11 @@ describe('BigQuery', () => {
},
{
query: QUERY_STRING,
schemaUpdateOptions: ['update']
}
schemaUpdateOptions: ['update'],
},
];

for (let index in testCases) {
for (const index in testCases) {
const testCase = testCases[index];
const req = bq.buildQueryRequest_(testCase, {});
assert.equal(req, undefined);
Expand Down