Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for TPC Universes #1333

Merged
merged 4 commits into from
Feb 12, 2024
Merged

feat: add support for TPC Universes #1333

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
05406d3
feat: add support for TPC Universes
alvarowolfx Feb 8, 2024
0d88564
fix: lint issues
alvarowolfx Feb 8, 2024
29f8d40
Merge branch 'main' into feat-tpc-universe
alvarowolfx Feb 9, 2024
4c7aa35
fix: remove tpc domain
alvarowolfx Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
fix: remove tpc domain
  • Loading branch information
@alvarowolfx
alvarowolfx committed Feb 9, 2024
commit 4c7aa35c40f8dc399f6e4d1adb494a966c562435
6 changes: 3 additions & 3 deletions test/bigquery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,18 +264,18 @@ describe('BigQuery', () => {
});

it('should allow overriding TPC universe', () => {
const universeDomain = 'apis-tpclp.goog/';
const universeDomain = 'fake-tpc-env.example.com/';
bq = new BigQuery({
universeDomain: universeDomain,
});
const calledWith = bq.calledWith_[0];
assert.strictEqual(
calledWith.baseUrl,
'https://bigquery.apis-tpclp.goog/bigquery/v2'
'https://bigquery.fake-tpc-env.example.com/bigquery/v2'
);
assert.strictEqual(
calledWith.apiEndpoint,
'https://bigquery.apis-tpclp.goog'
'https://bigquery.fake-tpc-env.example.com'
);
});

Expand Down