Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add soft delete feature #2403

Merged
merged 30 commits into from
Mar 14, 2024
Merged

feat: add soft delete feature #2403

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
26326a4
feat: add soft delete feature
JesseLovelace Feb 8, 2024
407af36
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 8, 2024
22ae88d
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 8, 2024
bd4bb67
Merge branch 'softdel' of https://github.com/googleapis/java-storage …
gcf-owl-bot[bot] Feb 8, 2024
d77aa58
add softDeleteTime and hardDeleteTime object fields
JesseLovelace Feb 9, 2024
a888e80
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace Feb 9, 2024
2a85a65
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 9, 2024
4f1b6de
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 9, 2024
fd22008
add new fields to field tests
JesseLovelace Feb 9, 2024
7142bcb
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace Feb 9, 2024
0f837d3
clirr ignore
JesseLovelace Feb 9, 2024
c2884aa
remove debug comments
JesseLovelace Feb 14, 2024
ac6022e
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 14, 2024
1c363ff
Merge branch 'main' into softdel
JesseLovelace Feb 28, 2024
dbe0d92
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 28, 2024
fb88608
add softdeletetime and harddeletetime to grpc codec
JesseLovelace Feb 28, 2024
04975fc
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 28, 2024
1de29b8
fix read mask test
JesseLovelace Feb 29, 2024
c98d8c7
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace Feb 29, 2024
3a4a00f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 29, 2024
b3d70db
fix style issues
JesseLovelace Feb 29, 2024
7986f9c
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace Feb 29, 2024
a93e162
Merge branch 'main' into softdel
JesseLovelace Mar 11, 2024
5a744ca
updates to apiary library
JesseLovelace Mar 11, 2024
0b8fe3f
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 11, 2024
be3e975
Merge branch 'main' into softdel
JesseLovelace Mar 14, 2024
5e65c40
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 14, 2024
938e00c
fix read mask test
JesseLovelace Mar 14, 2024
8f38221
Merge branch 'softdel' of github.com:googleapis/java-storage into sof…
JesseLovelace Mar 14, 2024
68ce8c0
fix typo
JesseLovelace Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
fix read mask test
  • Loading branch information
@JesseLovelace
JesseLovelace committed Feb 29, 2024
commit 1de29b89673c9c8a44b1755a122d39d8df6ceef3
7 changes: 6 additions & 1 deletion google-cloud-storage/src/test/java/com/google/cloud/storage/it/ITBucketReadMaskTest.java
View file
Open in desktop
Expand Up @@ -40,6 +40,8 @@
import com.google.cloud.storage.it.runner.annotations.SingleBackend;
import com.google.cloud.storage.it.runner.annotations.StorageFixture;
import com.google.common.collect.ImmutableList;

import java.time.temporal.ChronoUnit;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
Expand Down Expand Up @@ -134,7 +136,10 @@ public ImmutableList<?> parameters() {
new Args<>(BucketField.UPDATED, LazyAssertion.equal()),
new Args<>(BucketField.VERSIONING, LazyAssertion.equal()),
new Args<>(BucketField.WEBSITE, LazyAssertion.equal()),
new Args<>(BucketField.SOFT_DELETE_POLICY, LazyAssertion.equal()));
new Args<>(BucketField.SOFT_DELETE_POLICY, (jsonT, grpcT) -> {
assertThat(jsonT.getSoftDeletePolicy().getRetentionDuration().equals(grpcT.getSoftDeletePolicy().getRetentionDuration()));
assertThat(jsonT.getSoftDeletePolicy().getEffectiveTime().truncatedTo(ChronoUnit.SECONDS).equals(grpcT.getSoftDeletePolicy().getEffectiveTime().truncatedTo(ChronoUnit.SECONDS)));
}));

List<String> argsDefined =
args.stream().map(Args::getField).map(Enum::name).sorted().collect(Collectors.toList());
Expand Down