chore: replace client creation methods for all new samples with auto-generated admin clients #2927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…od while retrying exceptions in unit tests. * For details on issue see - googleapis#2206
fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.
olavloite
reviewed
Feb 23, 2024
samples/snippets/src/main/java/com/example/spanner/admin/generated/AddAndDropDatabaseRole.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/admin/generated/AddAndDropDatabaseRole.java
Show resolved
Hide resolved
…ated/AddAndDropDatabaseRole.java Co-authored-by: Knut Olav Løite <[email protected]>
olavloite
reviewed
Feb 24, 2024
| @@ -113,6 +113,7 @@ public static void afterClass() throws InterruptedException { | |||
| } | |||
| } | |||
| for (String backupId : idGenerator.getBackupIds()) { | |||
| System.out.println("Trying to delete " + backupId); | |||
There was a problem hiding this comment.
nit: I assume that this and the other System.out.println will be removed before merging.
There was a problem hiding this comment.
This is actually pretty useful. At the end of the test it prints if all the resources were cleaned up or not.
olavloite
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createDatabaseAdminClient()andcreateInstanceAdminClientmethods since it supports emulator.