chore: loosen restrictions setRetryAbortsInternally #2924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling setRetryAbortsInternally(boolean) was unnecessarily strict, as there is no reason why it should be disallowed to change the value while in auto-commit mode and/or read-only mode. The fact that the flag does not have any direct impact on those modes, does not mean that it should be disallowed to set the value. The fact that it was impossible to set the value while in auto-commit mode, also means that it is impossible to disable it using a startup command for a PostgreSQL connection to PGAdapter, as PGAdapter creates connections in auto-commit mode.
ankiaga
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling setRetryAbortsInternally(boolean) was unnecessarily strict, as there is no reason why it should be disallowed to change the value while in auto-commit mode and/or read-only mode. The fact that the flag does not have any direct impact on those modes, does not mean that it should be disallowed to set the value.
The fact that it was impossible to set the value while in auto-commit mode, also means that it is impossible to disable it using a startup command for a PostgreSQL connection to PGAdapter, as PGAdapter creates connections in auto-commit mode.